Repository navigation
[Backport release-1.6] fix(rabbitmq): right-size the default resources preset to s1.nano - #4393
Conversation
A default-sized RabbitMQ 4.2 broker was OOMKilled on t1.nano (128Mi) and never became Ready; its working set peaked at 125.8Mi. s1.nano keeps the 250m CPU and gives 512Mi. The resources and resourcesPreset descriptions now say the preset fills every resource that resources leaves unset. The parameter table and the cozyrd schema are regenerated from the 1.6 values, which carry no tls block. (cherry picked from commit 12e64a9) Signed-off-by: Yan Bondarenko <[email protected]>
The 1.6 rabbitmq Makefile has no test target, so the helm-unittest sweep never enters the package and the preset suite would sit there unrun. main gained the target earlier; this brings the same two lines. Signed-off-by: Yan Bondarenko <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: cozystack/cozystack/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What this PR does
Manual backport of #3936 to
release-1.6.The automated backport, #4372, pushed conflict markers in
packages/apps/rabbitmq/README.mdandpackages/system/rabbitmq-rd/cozyrds/rabbitmq.yamlas its only commit, so it would ship them if merged. Both are generated files, and the conflict is thetlsblock that landed on main after 1.6 was cut. Everything else applies unchanged, so two differences follow:tls;Makefilehas notesttarget, so the helm-unittest sweep would never enter the package and the new preset suite would not run. The second commit adds the same two lines main already has.Verified on this branch: the rabbitmq suite passes 4/4,
make -n testanswers the sweep probe, and a secondmake generateproduces no drift.Change summary, unchanged from #3936: the default
resourcesPresetmoves fromt1.nano(128Mi) tos1.nano(250m CPU, 512Mi), because a default-sized RabbitMQ 4.2 broker was OOMKilled ont1.nanoand never became Ready. TheresourcesandresourcesPresetdescriptions say the preset fills every resourceresourcesleaves unset.Close #4372 in favour of this one, or tell me to take a different route and I will.
Screenshots
Not a UI change.
Downstream repositories
Walked the trigger map against the diff: one app chart with a changed default. The provider follow-up is cozystack/terraform-provider-cozystack#34, labelled
target/1.7.Release note