Repository navigation
docs(ci): say why the overlay's ancestry tie goes to main - #4469
Conversation
The comment claimed a line fresh off main is the same as main, but the cozystack-packages:main artifact is built from main's tip, not from the cut commit. Once main moves past the cut, a stack on such a line gets newer images than the line's, until the stack holds a commit of the line's own. State that limit, and why the tie still goes to main: a branch forked from main before a cut ties the same way and is far more common. Assisted-by: LLM Signed-off-by: Aleksei Sviridkin <[email protected]>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: cozystack/cozystack/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe workflow comment now explains that a release line with no commits of its own ties with ChangesArtifact selection
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Merge Risk: ⚪ Minimal · up to The workflow behavior is unchanged, and the updated comment accurately describes artifact selection for stacked bases. No concrete merge risk was identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
size/S
IvanHunters
left a comment
IvanHunters
left a comment
There was a problem hiding this comment.
Verdict
LGTM
Comment-only change in .github/workflows/pull-requests.yaml; every claim it adds matches the tie-breaking script in the Pull base-branch packages tree step, and the new wording is more precise than the text it replaces.
Caveats
Verified against the step's own logic, not executed (no live CI run). The script seeds best from git rev-list --count origin/main..origin/$BASE_REF and switches to a line only on strict n < best, so a tie keeps ARTIFACT_REF=main: the new sentence "a tie goes to main" is exact. The replacement also tightens the old text: the line wins only once the stack itself contains a commit of the line's own (i.e. count(line..BASE_REF) < count(main..BASE_REF)), which is stricter and more correct than the previous "once the line has a commit of its own" (a line commit absent from the stack does not flip the count). The rationale for the default (a branch forked from main before the cut ties the same way, so tipping ties toward the line would misroute that common case) is consistent with the same count arithmetic.
2 participants
What this PR does
This fixes the comment on the overlay's ancestry tie, which described the wrong reason for the tie. No behaviour changes.
The comment said a line fresh off main is the same as main. That holds only for the graph.
cozystack-packages:mainis built from main's tip, so once main moves past the cut, a stack on such a line gets newer images than the line. The comment now says so. It also says why the tie still goes to main: a branch forked from main before the cut ties the same way, and that case is far more common.This follows up on a review note in #4460 and is stacked on it.
Screenshots
Downstream repositories
Release note
Summary by CodeRabbit
mainis preferred in a tie and how that may affect image freshness.