Repository navigation
[monitoring] create new version to include fix for vlogs image - #803
Conversation
WalkthroughThis pull request updates the versioning for the monitoring package. In the Chart.yaml file, the application version is bumped from 1.9.1 to 1.9.2. In parallel, the versions_map file is adjusted by changing the 1.9.1 version reference from a dynamic HEAD pointer to a fixed commit hash (fd24070) and by adding a new 1.9.2 entry set to HEAD. Changes
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/pre-commit.yml(1 hunks)packages/extra/monitoring/Chart.yaml(1 hunks)packages/extra/versions_map(1 hunks)
🔇 Additional comments (2)
packages/extra/monitoring/Chart.yaml (1)
6-6: Version bump to 1.9.2The monitoring chart version has been incremented from 1.9.1 to 1.9.2, which aligns with the changes in the versions_map file.
packages/extra/versions_map (1)
37-38: Version mapping updated correctlyGood practice to lock the previous version (1.9.1) to a specific commit and add the new version (1.9.2) pointing to HEAD. This ensures version stability and proper version control.
| jobs: | ||
| pre-commit: | ||
| runs-on: ubuntu-22.04 | ||
| runs-on: [self-hosted] |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Workflow now uses self-hosted runner
This change shifts from a standard GitHub-hosted Ubuntu runner to a self-hosted runner. Ensure that the self-hosted runner has pre-commit and all necessary dependencies pre-installed since the installation steps have been removed from the workflow.
🏁 Script executed:
#!/bin/bash
# Check if pre-commit is available on the self-hosted runner
pre-commit --version
# Check what Python version is available
python --version
# List installed packages that might be relevant
pip list | grep -E 'pre-commit|yamllint|markdownlint'Length of output: 260
Self-hosted Runner Dependency Missing: Pre-commit Not Found
It has been verified that while the self-hosted runner has Python (3.11.2) and yamllint installed, the pre-commit tool is currently missing from the environment. This confirms that the removal of the pre-commit installation step in the workflow has caused a dependency gap. Please ensure that either the self-hosted runner is pre-configured with pre-commit (and any other necessary tools like markdownlint if used) or adjust the workflow to install these dependencies before running pre-commit hooks.
- File:
.github/workflows/pre-commit.yml(Line 12) - Issue:
pre-commitcommand not available on the runner
8c7e141 to
ca71d4b
Compare
Signed-off-by: kklinch0 <[email protected]>
ca71d4b to
f507802
Compare
Andrei Kvapil (kvaps)
changed the title
Andrei Kvapil (kvaps)
changed the title
Andrei Kvapil (kvaps)
changed the title
2 participants
Summary by CodeRabbit