Repository navigation
docs(platform-stack): bump etcd-operator to v0.4.3 - #501
Conversation
Accompanies cozystack/cozystack#2428 which updates the vendored chart and adds the S3 backup schedule API surface. Assisted-By: Claude <[email protected]> Signed-off-by: Aleksei Sviridkin <[email protected]>
✅ Deploy Preview for cozystack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughUpdated the Etcd Cluster documentation to change the etcd operator reference from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the etcd-operator version to v0.4.3 in the platform stack documentation. The review feedback suggests renaming the 'Operator' label to 'Kubernetes operator' to maintain consistency with other sections of the guide.
|
|
||
| - Supported version: Kubernetes v1.32.4 | ||
| - Operator: [aenix-io/etcd-operator](https://github.com/aenix-io/etcd-operator) v0.4.2 | ||
| - Operator: [aenix-io/etcd-operator](https://github.com/aenix-io/etcd-operator) v0.4.3 |
There was a problem hiding this comment.
For consistency with other sections in this document (such as ClickHouse, Kafka, and MariaDB), consider using the label Kubernetes operator instead of just Operator.
| - Operator: [aenix-io/etcd-operator](https://github.com/aenix-io/etcd-operator) v0.4.3 | |
| - Kubernetes operator: [aenix-io/etcd-operator](https://github.com/aenix-io/etcd-operator) v0.4.3 |
There was a problem hiding this comment.
Applied in 8f90d21. The etcd section now uses Kubernetes operator: to match the other six entries (ClickHouse, Kafka, MariaDB, PostgreSQL, RabbitMQ, Redis) — confirmed with grep -n '^-\s\+\(Kubernetes operator\|Operator\):' that etcd was the only outlier.
Address review feedback from gemini-code-assist on content/en/docs/v1.2/guides/platform-stack/_index.md:173: align the etcd section label with the other operator entries (ClickHouse, Kafka, MariaDB, PostgreSQL, RabbitMQ, Redis), which all use 'Kubernetes operator:'. Signed-off-by: Aleksei Sviridkin <[email protected]>
Maxim Kitsunoff (kitsunoff)
left a comment
Maxim Kitsunoff (kitsunoff)
left a comment
There was a problem hiding this comment.
LGTM — version bump matches the merged cozystack/cozystack#2428.
3 participants
What this PR does
Bumps the pinned etcd-operator version in the v1.2 platform-stack guide from
v0.4.2tov0.4.3.Accompanies cozystack/cozystack#2428, which re-vendors the chart and adds the
backup.*API surface on the managed etcd app. The new backup parameters will land incontent/en/docs/v1.2/operations/services/etcd.mdautomatically when the release-tag sync job pulls the updatedpackages/extra/etcd/README.md— no hand-edited doc is needed here.Summary by CodeRabbit