Repository navigation
chore(i18n): refresh landing-page source digests to unblock i18n-lint - #689
IvanHunters wants to merge 1 commit into
Conversation
content/en/_index.md gained a Live Demo section in 480d6da without refreshing the translation digests, so i18n-lint fails on main and on every PR that touches content/. This records the current English digest on the de/hi/ru/zh-cn landing pages so the freshness gate passes again. This does not re-translate the new section: the de/hi/ru/zh-cn home pages still need the Live Demo block; this only clears the stale-digest gate so CI is green while that translation is done separately. Signed-off-by: IvanHunters <[email protected]>
✅ Deploy Preview for cozystack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughFour localized index pages update their ChangesLocalization digest updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates source-digest metadata for four localized landing pages so they track the current English page and pass localization freshness checks. No user-facing content or runtime behavior changes, and the change is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Aleksei Sviridkin (lexfrei)
left a comment
Aleksei Sviridkin (lexfrei)
left a comment
There was a problem hiding this comment.
NOT LGTM: this records the four landing pages as current translations of an English page that gained a section they do not have.
Business context: i18n-lint has been red on main and on every content PR since 480d6daa, for a break none of them caused (#652).
Blockers
-
480d6daaadded a section tocontent/en/_index.md: asection-live-demoblock with a heading, a paragraph and a/demo/call to action (content/en/_index.md:79-88). The de/hi/ru/zh-cn pages carry the same shortcodes in the same order and each one runs straight fromhome/screenshot-gallerytohome/benefits. These are transcreations, so divergence can be deliberate, but here the block just is not there. They also keeptranslation_status: current, which this PR leaves alone.hack/check-i18n.shis the only thing in the repo that readssource_digest, and there is no re-translation tooling, so once the digest matches nothing records the gap.check-i18n.sh:137says "refresh the translation, then run 'hack/check-i18n.sh update-digests'", and #652 reserves the digest-only path for an English edit cosmetic enough not to affect the translated text. This one added content.The block is eleven lines and the four pages already have the surrounding shortcodes in place, so a transcreated Live Demo section in each is about the size of this diff. Refresh the digests after that. If the translation has to wait, file the tracking issue now and take
translation_statusoffcurrent, so the gap lives in the tree instead of only in this thread.
Follow-ups, not blocking
- Worth linking #652 from the PR body. Either way only half of it closes.
update-digestswith no arguments re-stamps every page carrying asource_digestfrom the current English source and never checks that the translation moved (check-i18n.sh:144-165). That is what makes a one-line green possible, and it will get reached for again. An update mode limited to pages the working tree changed would close it.- Also pre-existing:
translated_digest_filesmatches^source_digest:over the whole file (check-i18n.sh:64-66) andupdate_digestsrewrites the first hit wherever it sits, so a future page documenting the i18n pipeline with a column-zerosource_digest:inside a fence gets selected and rewritten. Nothing in the tree hits this today.
| description: "Open-Source-Cloud-Plattform auf Kubernetes für Managed VMs, Datenbanken, S3-Storage und GPU-Workloads. CNCF-Sandbox-Projekt." | ||
| keywords: ["private cloud", "managed kubernetes", "kubernetes plattform", "open source cloud"] | ||
| source_digest: "sha256:24e38da4716b93c35dcb9eb607152d193ef3d5ad42c0e22a25063a89da9f8dde" | ||
| source_digest: "sha256:e8f982c2431355bc79d3bb2133781cc539553c4c0a293d36e4c23dc54e7fcf80" |
There was a problem hiding this comment.
The English page gained a section-live-demo block in 480d6daa (content/en/_index.md:79-88) and this page still goes from home/screenshot-gallery to home/benefits. Recording the new digest marks it current while the section is missing, and check-i18n.sh is the only thing tracking that. Same for hi, ru and zh-cn.
|
Superseded: the translations were refreshed on main instead, i18n-lint is green again without the digest bump. |
2 participants
What
Refreshes the recorded
source_digeston the four translated landing pages (content/de|hi|ru|zh-cn/_index.md) to the current digest ofcontent/en/_index.md.Why
content/en/_index.mdgained a Live Demo section in 480d6da without refreshing the translation digests. Since theni18n-lintfails onmainand on every PR that touchescontent/(e.g. #672), reporting the four landing pages as stale. This clears the freshness gate.Scope
Digest-only: the diff is a single
source_digestline per file, nothing else.hack/check-i18n.shpasses after the change (translation freshness: OK).This does not re-translate the new Live Demo block into de/hi/ru/zh-cn; those home pages still need it. This only unblocks CI so that translation can be done separately.
Summary by CodeRabbit