Repository navigation
Regroup ghostel.el functions into topic sections - #671
Merged
Merged
Conversation
Add an "Internal helpers" section for ghostel--ensure-ghostel-buffer and ghostel--run-hook-safely (moved from ghostel-shell.el, which forward declares it), a "Copying text" section for the copy filters and commands, and a "Mode hooks" section for the hook functions that had accumulated at the end of "Window resize". Move the scroll-wheel forwarder to "Mouse input", the read-only motions next to the other read-only commands, ghostel--pos-on-cursor-p to the cursor-state queries, and ghostel--local-host-p beside its only caller.
The mode-line tag/progress helpers are driven by input modes, OSC 9;4 progress, the spinner, and the password indicator alike; cursor blink and ghostel--apply-cursor-style are not native callbacks; and the identity functions are shared with bookmark, desktop, consult, and compile. Give each group a section header instead of leaving them inside "Input modes - state helpers", "Callbacks from native module", and "Entry point".
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure moves in
lisp/ghostel.el(plus one function relocated fromghostel-shell.el); no function bodies or docstrings change.Commit 1 — misplaced functions
;;; Internal helperssection forghostel--ensure-ghostel-bufferandghostel--run-hook-safely. The latter moves fromghostel-shell.elinto core (its callers areghostel--sentineland the OSC 133 handlers);ghostel-shell.elnow forward-declares it.;;; Copying textsection:ghostel--filter-soft-wraps,ghostel--clean-copy-text,ghostel--filter-buffer-substring,ghostel-readonly-copy,ghostel-copy-all.;;; Mode hookssection for the hook functions that had accumulated at the end of "Window resize".ghostel--forward-scroll-event→ Mouse input;ghostel-readonly-end-of-buffer/-end-of-line→ next to the other read-only commands;ghostel--pos-on-cursor-p→ cursor-state queries;ghostel--local-host-p→ besideghostel--update-directory, its only caller.Commit 2 — new sections for shared groups
;;; Mode line: theghostel--mode-line-*tag/progress helpers (driven by input modes, OSC 9;4 progress, the spinner and the password indicator).;;; Cursor style: cursor blink andghostel--apply-cursor-style(were under "Callbacks from native module").;;; Buffer identity: the identity functions shared with bookmark, desktop, consult-ghostel and compile (were under "Entry point").make -j8 allpasses after each commit.