Repository navigation
Exclude trailing sentence punctuation from detected file links - #687
Merged
Merged
Conversation
A path ending a sentence, like "written to /tmp/notes.md.", absorbed the mark into the candidate and failed the existence check. The path regex now ends the same way the URL regex does: its last character is never one of ".,;!?".
dakra
force-pushed
the
fix/link-trailing-punctuation
branch
from
September 14, 2026 10:49
221a252 to
fd3c0c6
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Output like
Handoff written to /tmp/notes.md.produced no link: the path regex absorbed the sentence-ending dot, so the candidatenotes.md.failed the existence check.The default of
ghostel-file-detection-path-regexnow ends the same wayghostel--url-regexdoes: the last path character is never one of.,;!?. Punctuation inside a path stays legal, and:LINE[:COL]tails were already unaffected.Benchmarks (
bench/run-bench.sh --case, two passes each, ITER ms):All within run-to-run noise.