Repository navigation
Bump libghostty to 0c2a290d3 - #688
Merged
Merged
Conversation
Adapt to the ghostty-vt module API since ab0b9da9e: - Terminal.Options.max_scrollback is max_scrollback_bytes - DynamicPalette.changeDefault takes an allocator and can fail - Stream.initAlloc is gone; use Stream.init with an options struct - the write_pty effect receives a plain slice - kitty Image.data is a union; read it through renderData().bytes() - kitty Placement.Location gained a relative variant, drawn via the resolved parent chain when it roots at a pin, clipped on all four edges like upstream, with pruned anchor pins skipped Stored kitty images are never PNG anymore (the decode hook converts them at transmit time), so the PNG pass-through and the is-png parameter of the Elisp display functions are removed.
dakra
force-pushed
the
chore/ghostty-bump
branch
from
September 14, 2026 16:05
f2a8fee to
2bdf4c3
Compare
Two plain-ghostel (evil-free) regression scenarios plus their shared setup helper. kitty-ghostel.json (GUI) covers pinned and relative placements, deletion, the overlay path, virtual placeholders, and placement eviction; scrollback-ghostel.json (TTY) covers eviction, a DECSTBM region scroll, wrapped-line rejoin on a widening resize, and a DECCOLM round trip.
dakra
force-pushed
the
chore/ghostty-bump
branch
from
September 14, 2026 21:17
b0a5e33 to
7ddd90e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the vendored ghostty-vt module from
ab0b9da9e(2026-07-22) to0c2a290d3(2026-09-14) and adapts ghostel to the module API changes.API adaptations
Terminal.Options.max_scrollbackis nowmax_scrollback_bytes.DynamicPalette.changeDefaulttakes an allocator and can fail; the palette setter propagates the error.Stream.initAllocis gone; streams useStream.initwith an options struct (three call sites).write_ptyeffect receives a plain slice instead of a sentinel-terminated one.kitty.Image.datais now a union; image bytes are read throughrenderData().bytes().kitty.graphics.Placement.Locationgained arelativevariant (P=/Q=/H=/V=). Relative placements rooted at a pin are drawn via the resolved parent chain, clipped on all four edges like upstream, with pruned anchor pins skipped. Chains rooted at a virtual placement are not drawn.Stored kitty images are never PNG anymore (the decode hook converts them to RGBA at transmit time), so the PNG pass-through and the now-dead
is-pngparameter of the Elisp display functions are removed.make -j8 allpasses.Behavior note
Upstream now deletes an image and its placements when an explicit id is retransmitted (ghostty commit
e5747cf0b). Programs that recycle an image id, such as timg for runs in the same second, will see an earlier on-screen copy replaced rather than kept. This is intentional upstream behavior; ghostel still preserves copies already scrolled into materialized scrollback.