States without etag is handled differently in gRPC and HTTP APIs #405

Activity

1. artursouza

   added

   kind/bugSomething isn't workingSomething isn't working

   good first issueGood for newcomersGood for newcomers

   area/client

   P2

   on Dec 8, 2020
2. arghya88 commented on Dec 11, 2020

   

   arghya88

   on Dec 11, 2020

   Last edited by arghya88

   Contributor

   More actions

   I was looking at this and it seems it's happening because DaprProtos.GetStateResponse has etag_ = "";

   public static final class GetStateResponse extends
         com.google.protobuf.GeneratedMessageV3 implements
         // @@protoc_insertion_point(message_implements:dapr.proto.runtime.v1.GetStateResponse)
         GetStateResponseOrBuilder {
     private static final long serialVersionUID = 0L;
       // Use GetStateResponse.newBuilder() to construct.
       private GetStateResponse(com.google.protobuf.GeneratedMessageV3.Builder<?> builder) {
         super(builder);
       }
       private GetStateResponse() {
         data_ = com.google.protobuf.ByteString.EMPTY;
         etag_ = "";
       }
   

   This is being picked up here https://github.com/dapr/java-sdk/blob/master/sdk/src/main/java/io/dapr/client/DaprClientGrpc.java#L334
   @artursouza what would be the way to fix this?
3. artursouza commented on Dec 14, 2020

   

   artursouza

   on Dec 14, 2020

   ContributorAuthor

   More actions

   This should be fixed in the runtime ideally. In my opinion, the fallback is for the SDK to convert empty string to null for GRPC and HTTP implementation to keep them consistent.
4. artursouza

   assigned

   arghya88

   on Dec 16, 2020
5. artursouza

   added

   breaking-change

   on Dec 16, 2020
6. artursouza

   closed this as completedin #414on Dec 18, 2020