Potential issue in io.dapr.client.DaprClientHttp#executeStateTransaction

In io.dapr.client.DaprClientHttp#executeStateTransaction, there's one line of code like below:

java-sdk/sdk/src/main/java/io/dapr/client/DaprClientHttp.java

Line 398 in 9c5084b

operations.add(new TransactionalStateOperation<>(operation.getOperation(),

Instead, I believe the right logic should be:

        // Custom serializer, so everything is byte[].
        internalOperationObjects.add(new TransactionalStateOperation<>(operation.getOperation(),
            new State<>(state.getKey(), data, state.getEtag(), state.getMetadata(), state.getOptions())));

@beiwei30

@beiwei30 Yes, this is a bug. We need to fix this ASAP. I was planning on releasing 1.0.1 today but I will work on this instead and add it to the hotfix release. We also need IT to make sure this bug does not come back. nice catch!

This issue is not present in the gRPC client, which is what is used by default in the SDK. So, it is not as urgent. Still, I am working on the fix.

Navigation Menu

Repository navigation

Potential issue in io.dapr.client.DaprClientHttp#executeStateTransaction #514

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Potential issue in io.dapr.client.DaprClientHttp#executeStateTransaction #514

Description

Activity

artursouza commented on Mar 16, 2021

artursouza commented on Mar 16, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions