Repository navigation
[REOPENED] Maven configuration files need to be optimised #531
Description
Activity
@LLLLimbo I saw your PR. We are open to optimizations but we need to know the motivations and avoid side effects. For example, the dependencies for each project must remain as-is even with this refactoring. I will ask questions in the PR directly.
As a rule of thumb, PRs without a discussion in an issue tend to take longer to be merged or may be rejected.
@LLLLimbo Build is broken with the PR above. Can you fix it?
@LLLLimbo We figured out that it failed on your PR as a coincidence. We had creds rotated recently because of the CodeCov drill. We are fixing this. Thanks for being open about it.
Closing this issue.
Reopening since we found a regression. There was indeed an issue in how the creds were rotated but this PR also added another issue. The deployment of the jars are being skipped now.
@LLLLimbo We are happy to take on another PR if this regression can be addressed. We are reverting this change from master for now.
See step "Publish to ossrh" in this run: https://github.com/dapr/java-sdk/runs/2471510564?check_suite_focus=true
- changed the title
[-]Maven configuration files need to be optimised[/-][+][REOPENED] Maven configuration files need to be optimised[/+]on Apr 30, 2021 Reopening since we found a regression. There was indeed an issue in how the creds were rotated but this PR also added another issue. The deployment of the jars are being skipped now.
@LLLLimbo We are happy to take on another PR if this regression can be addressed. We are reverting this change from master for now.
See step "Publish to ossrh" in this run: https://github.com/dapr/java-sdk/runs/2471510564?check_suite_focus=true
I'll take on another PR later.
Describe the proposal
The current configuration is not easy to manage and I think it would be better to make some adjustments.
I will create a pr later.
RELEASE NOTE: N/A