Repository navigation
Make the DAPR version being used consistent across all tests - #1299
Merged
artur-ciocanu merged 11 commits intoApr 18, 2025
Merged
artur-ciocanu merged 11 commits into
artur-ciocanu merged 11 commits into
Conversation
Contributor
Author
|
The tests are failing with scheduler not available. Will wait for Jobs SDK PR to merge and then work on this PR |
artur-ciocanu
requested changes
Apr 8, 2025
artur-ciocanu
left a comment
artur-ciocanu
left a comment
Contributor
There was a problem hiding this comment.
@siri-varma very nice PR, I have left a tiny comment, could you please address and resend and I will approve.
Thank you!
commented
Apr 17, 2025
Contributor
|
@siri-varma could you please check the conflicts and address the comments. Thank you. |
added 5 commits
April 17, 2025 10:52
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
siri-varma
force-pushed
the
users/svegiraju/make-version-consistent
branch
from
April 17, 2025 07:01
3ac03e3 to
12f1150
Compare
added 5 commits
April 17, 2025 12:33
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
siri-varma
commented
Apr 17, 2025
Signed-off-by: siri-varma <[email protected]>
commented
Apr 17, 2025
Contributor
Author
|
@artur-ciocanu addressed all the comments and merge conflicts. These changes are ready to review as well |
artur-ciocanu
approved these changes
Apr 18, 2025
commented
Apr 18, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1299 +/- ##
============================================
- Coverage 76.91% 76.87% -0.04%
- Complexity 1592 1719 +127
============================================
Files 145 200 +55
Lines 4843 5272 +429
Branches 562 574 +12
============================================
+ Hits 3725 4053 +328
- Misses 821 903 +82
- Partials 297 316 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make the dapr version being used consistent across all tests
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1296
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: