Repository navigation
Refactoring properties and constants. - #333
Merged
Merged
Conversation
pruthvidhodda
previously approved these changes
Sep 1, 2020
Contributor
|
Looks like there are some more places where Constants reference needs to be removed, else the changes LGTM |
mukundansundar
suggested changes
Sep 2, 2020
mukundansundar
previously approved these changes
Sep 2, 2020
mukundansundar
approved these changes
Sep 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move constants to correct corresponding owner class.
Remove Constants class.
Add SIDECAR_IP env var and property (defaults to 127.0.0.1).
Refactor properties to support reference to name and not only value.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: N/A
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: