No automatic hyperlinking in HTML fragments #1467

Activity

1. Hixie

   added

   customer-flutterIssues originating from important to FlutterIssues originating from important to Flutter

   P2A bug or feature request we're likely to work onA bug or feature request we're likely to work on

   on Jun 22, 2017
2. srawlins commented on Jul 11, 2017

   

   srawlins

   on Jul 11, 2017

   Member

   More actions

   The dartdoc package uses package:markdown, which mostly supports GitHub-flavored Markdown tables. Are these enabled in dartdocs?
3. srawlins commented on Jul 11, 2017

   

   srawlins

   on Jul 11, 2017

   Member

   More actions

   @Hixie , I don't understand. I don't see a # fragment in your URL that you link...
4. Hixie commented on Jul 11, 2017

   

   Hixie

   on Jul 11, 2017

   ContributorAuthor

   More actions

   @srawlins I literally meant "HTML fragment", as in, a fragment of HTML, not URL fragment identifiers.
   The source for the above is at: https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/widgets/framework.dart#L2557
5. srawlins commented on Jul 11, 2017

   

   srawlins

   on Jul 11, 2017

   Member

   More actions

   Oh sorry. That's not part of the Markdown spec. You'll notice the backticks aren't converted to <code> either.

   If you use the GFM markdown syntax, it might work.
6. Hixie commented on Jul 11, 2017

   

   Hixie

   on Jul 11, 2017

   ContributorAuthor

   More actions

   What does that mean? :-)
7. Hixie commented on Jul 11, 2017

   

   Hixie

   on Jul 11, 2017

   ContributorAuthor

   More actions

   Also, what markdown spec?
8. srawlins commented on Jul 11, 2017

   

   srawlins

   on Jul 11, 2017

   Member

   More actions

   The markdown package tries to follow the CommonMark spec, or, if you use ExtensionSet.gitHub (which I think dartdocs does... or at least should), the GFM spec.

   In this case, using GFM tables:

   |                 | `newWidget == null` | `newWidget != null`
   |-----------------|---------------------|-----------------------
   | `child == null` | Returns null.       | Returns new [Element].
   | `child != null` | Old child is removed, returns null. | Old child updated if possible, returns child or new [Element]. |
   
9. Hixie commented on Jul 11, 2017

   

   Hixie

   on Jul 11, 2017

   ContributorAuthor

   More actions

   Pretty sure I tried that and it didn't work, and when I complained, I was told to use <table> markup. :-)
   There is a bug about supporting that: #1453

   BTW, dartdoc definitely doesn't follow that spec, at least not exclusively. In particular, hyperlinks to members aren't a syntax covered by that spec as far as I can tell. Nor are macros.
10. srawlins commented on Jul 11, 2017

    

    srawlins

    on Jul 11, 2017

    Member

    More actions

    OK good, so there is a known issue.

    Yeah I guess custom link resolvers are a customization. We just allow shortcut reference links without a link reference definition, which then gets sent to a link resolver to answer "this might be a link. do you think it's a link? where should it point to?"
11. jcollins-g

    closed this as completedin flutter/flutter#20721on Aug 17, 2018