Repository navigation
Update testExecutable signature in documentation - #245
Merged
polina-c merged 1 commit intoSep 28, 2024
Merged
Conversation
Contributor
Author
|
cc @polina-c |
Contributor
Author
|
I believe this doesn't need a CHANGELOG entry/version bump/tests ? |
8 of 11 tasks
polina-c
approved these changes
Sep 9, 2024
|
auto label is removed for dart-lang/leak_tracker/245, due to This PR has not met approval requirements for merging. The PR author is not a member of dart-team and needs 1 more review(s) in order to merge this PR.
|
Contributor
|
Yes, no changelog is needed. |
Contributor
Author
|
Is there something to do for this PR ? |
Contributor
|
Merged. Thank you and sorry for delays! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In flutter/packages#7546 I discovered that the signature of
testExecutableshould beto be able to compile the tests for the chrome platform.
This PR updates the documentation.
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.