Repository navigation
[native_assets_cli] Stop running link hooks in JIT mode. #1252
Description
We should stop running link hooks for JIT targets.
- The hooks can't do anything meaningful over build hooks due to not having treeshaking info ([native_assets_builder] Add
hook/link.dart#153). - Their "map-reduce"-like behavior means that many assets will be touched on rebuilds (cold start JIT, hot reload, hot restart ([native_assets_cli][native_assets_builder] Hot reload and hot restart #1207)).
The price to pay is that in JIT-mode, a build hook needs to do the linking. So likely, there'll be some shared logic between the build and link hooks in packages that have a link hook.
And we need an API for BuildConfig detailing if the link hooks will be run: bool BuildConfig.hasLinkPhase?
- Add
BuildConfigfield. - Stop running link hooks in JIT mode (Dart and Flutter PRs).
- Add proper documentation.
Thanks @mkustermann @mosuem @HosseinYousefi @liamappelbe! Please leave additional suggestions, thoughts, etc!
Activity
mosuem commentedon Jul 3, 2024
Documentation/Messaging on this is important, as we don't want people wondering why their link hooks did or did not run, or even worse, why some assets are there/missing if compiling in JIT vs. AOT.
[native_assets_builder] Publish 0.8.0 (#1286)
[native_assets] Stop running link hooks in JIT mode
[native_assets] Stop running link hooks in JIT mode (#151534)