Missing quickfix "update import" when hide is used in import #30503

Activity

1. lrhn

   added

   legacy-area-analyzerUse area-devexp instead.Use area-devexp instead.

   on Aug 21, 2017
2. bwilkerson

   added

   devexp-serverIssues related to some aspect of the analysis serverIssues related to some aspect of the analysis server

   P2A bug or feature request we're likely to work onA bug or feature request we're likely to work on

   type-enhancementA request for a change that isn't a bugA request for a change that isn't a bug

   on Aug 25, 2017
3. bwilkerson

   added

   devexp-quick-fixIssues with analysis server (quick) fixesIssues with analysis server (quick) fixes

   on Jan 28, 2018
4. bwilkerson commented on Jan 28, 2018

   

   bwilkerson

   on Jan 28, 2018

   Member

   More actions

   Agreed. We need to update FixProcessor._addFix_importLibrary_withElement to understand hide clauses.
5. asashour commented on Sep 10, 2021

   

   asashour

   on Sep 10, 2021

   Contributor

   More actions

   Another question, what happens when the user tries to expose the 'hidden' function, e.g.

   import 'dart:math' hide max show min;
   
   void f() {
     max(1, 2);
   }

   Should we say: Update library import, or Unhide 'max'?

   ---

   The requester test case:

   import 'dart:math' hide atan show min;
   
   void f() {
     max(1, 2);
   }

   should have 'Update library import' to add max, instead of 'Import library'
6. bwilkerson commented on Sep 23, 2021

   

   bwilkerson

   on Sep 23, 2021

   Member

   More actions

   The labels for a fix (or assist) should describe what it's going to do. We could say "Update import of ''", or we could be more specific about how it's going to be updated and say something like "Show '' from '' or "Unhide '' from ''" depending on how the import will be updated.

   For something like

   import 'dart:math' hide max show min;
   
   void f() {
     max(1, 2);
   }
   

   We actually need to do both: remove the hide clause and add max to the show clause. (I suspect that having both a hide and show clause is rare though, so I'm not sure it's worth having a third message for it.)
7. FMorschel commented on Aug 30, 2024

   

   FMorschel

   on Aug 30, 2024

   Contributor

   More actions

   We actually need to do both: remove the hide clause and add max to the show clause. (I suspect that having both a hide and show clause is rare though, so I'm not sure it's worth having a third message for it.)

   In this case the "update" would be fine I think.

   Just to point out: some work related to show is being worked on Dart-Code/Dart-Code#5238.
8. FMorschel commented on Oct 18, 2024

   

   FMorschel

   on Oct 18, 2024

   Contributor

   More actions

   I just would like to point out that there is an issue for warning when you have either two combinations of show/hide since you only need one to achieve any hiding goal

   You never need more than one show or one hide combinator to achieve any hiding-goal.

   From @lrhn's comment on #56879
9. FMorschel commented on Oct 19, 2024

   

   FMorschel

   on Oct 19, 2024

   Contributor

   More actions

   https://dart-review.googlesource.com/c/sdk/+/390630
10. copybara-service

    closed this as completedin 10db3deon Oct 23, 2024
11. copybara-service

    added a commit that references this issue on Oct 23, 2024

    [DAS] "Update library import" edit hide

    ...

    10db3de