DartFixKind.ADD_CURLY_BRACES_MULTI never shows up #49079

Activity

1. lrhn

   added

   legacy-area-analyzerUse area-devexp instead.Use area-devexp instead.

   on May 22, 2022
2. scheglov

   added

   devexp-quick-fixIssues with analysis server (quick) fixesIssues with analysis server (quick) fixes

   P4

   on May 23, 2022
3. asashour commented on Jun 29, 2022

   

   asashour

   on Jun 29, 2022

   Contributor

   More actions

   Having a multi option doesn't mean it is used for always_put_control_body_on_new_line. It is used for curly_braces_in_flow_control_structures

   Please see

   sdk/pkg/analysis_server/lib/src/services/correction/fix_internal.dart

   Lines 360 to 362 in eec1494

   	LintNames.always_put_control_body_on_new_line: [
   	UseCurlyBraces.nonBulk,
   	],

   and the below for explanation

   sdk/pkg/analysis_server/lib/src/services/correction/dart/use_curly_braces.dart

   Lines 23 to 26 in eec1494

   	/// This is used in places where "Use Curly Braces" is a valid manual fix, but
   	/// not clearly the only/correct fix to apply automatically, such as the
   	/// `always_put_control_body_on_new_line` lint.
   	UseCurlyBraces.nonBulk() : canBeAppliedInBulk = false;
4. srawlins

   added

   type-bugIncorrect behavior (everything from a crash to more subtle misbehavior)Incorrect behavior (everything from a crash to more subtle misbehavior)

   on Mar 14, 2024
5. bwilkerson

   added

   area-devexpFor issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages.For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages.

   and removed

   legacy-area-analyzerUse area-devexp instead.Use area-devexp instead.

   on Feb 21, 2025
6. keertip commented on Sep 30, 2026

   

   keertip

   on Sep 30, 2026

   Contributor

   More actions

   This is resolved. Shortly after this was filed, https://dart-review.googlesource.com/c/sdk/+/246120 (in 2.18.0-152.0.dev) registered "Add curly braces" as a fix for always_put_control_body_on_new_line, with single-file applicability. So "Add curly braces everywhere in file" is now offered for this lint. It is not applied by dart fix, because braces are not the only valid fix for that lint.

   Verified on a local build of main (3.14.0-edge.17e7a7c8bdb3ecc5cfcdf15d39daf2bd0ae8b443): ControlBodyOnNewLineInFileTest in pkg/analysis_server/test/src/services/correction/fix/use_curly_braces_test.dart, which covers the fix-all-in-file result for this lint, passes.

   If there is more work to do here, please let us know by filing a new issue with up to date information. Thanks!
7. keertip

   closed this as completedon Sep 30, 2026
8. keertip

   added

   closed-by-an-agentThis label is applied when an issue is closed by an agent.This label is applied when an issue is closed by an agent.

   on Sep 30, 2026