Repository navigation
no_leading_underscores_for_local_identifiers doesn't complain about local functions #58715
Description
The following code does not produce a no_leading_underscores_for_local_identifiers lint, even though I would have expected it to complain about _bar:
int foo() {
int _bar() { // Why no no_leading_underscores_for_local_identifiers lint here?
return 10;
}
return _bar();
}Complaining here would also seem to be in line with "Effective Dart" [1] (emphasize mine):
There is no concept of “private” for local variables, parameters, local functions, or library prefixes. When one of those has a name that starts with an underscore, it sends a confusing signal to the reader. To avoid that, don’t use leading underscores in those names.
Activity
goderbauer commentedon Apr 25, 2022
For extra context, I noticed this while reviewing flutter/flutter#102419. The tests there use local functions with leading underscores and our analysis check is green with the
no_leading_underscores_for_local_identifiersenabled.pq commentedon Apr 25, 2022
100% agreed. This one was just an oversight. Fixing now.
Thanks!