Skip to content

RPCError is incorrectly re-encoded as kServerError in vmService #61757

Closed
Closed
RPCError is incorrectly re-encoded as kServerError in vmService#61757
Assignees
jyameo
Labels
P2A bug or feature request we're likely to work onarea-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.triagedIssue has been triaged by sub teamtype-bugIncorrect behavior (everything from a crash to more subtle misbehavior)vm-serviceThe VM Service Protocol, both the specification and its implementation

Description

@jyameo
jyameo
opened on Oct 20, 2025

The _routeRequest method in vm_service.dart has a bug where it catches and re-encodes RPCError exceptions as kServerError, losing the original error code and information.

This causes issues when code specifically throws an RPCError with a particular error code (e.g., kIsolateCannotReload), as that error code is lost and replaced with kServerError.

Expected Behavior
When an RPCError is thrown, it should be preserved as-is without re-encoding. Only non-RPCError exceptions should be wrapped as kServerError.

Activity

  1. jyameo
    self-assigned this
    on Oct 20, 2025
  2. jyameo
    added
    vm-serviceThe VM Service Protocol, both the specification and its implementation
    on Oct 20, 2025
  3. devoncarew
    added
    area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
    on Oct 20, 2025
  4. github-merge-queue
    added a commit that references this issue on Oct 20, 2025

    Fixed hot reload/restart crashes after closing browser tab on web-ser…

    47d35a2
  5. srujzs
    added
    P2A bug or feature request we're likely to work on
    type-bugIncorrect behavior (everything from a crash to more subtle misbehavior)
    triagedIssue has been triaged by sub team
    on Oct 20, 2025
  6. copybara-service
    closed this as completedin bb0ae6con Oct 29, 2025
  7. pull
    added a commit that references this issue on Oct 29, 2025

    The _routeRequest method in vm_service.dart has a bug where it catche…

    bb0ae6c
  8. reidbaker
    added a commit that references this issue on Dec 10, 2025

    Fixed hot reload/restart crashes after closing browser tab on web-ser…

    5bb5759
  9. Nakiha
    added a commit that references this issue on Sep 28, 2026

    Fixed hot reload/restart crashes after closing browser tab on web-ser…

    c630416
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2A bug or feature request we're likely to work onarea-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.triagedIssue has been triaged by sub teamtype-bugIncorrect behavior (everything from a crash to more subtle misbehavior)vm-serviceThe VM Service Protocol, both the specification and its implementation

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions