Skip to content

CI broken: The ipykernel.comm.Comm class has been deprecated #7688

Description

@crusaderky

CI is broken on Python 3.10 and 3.11.
Many tests fail with the message:

DeprecationWarning: The ipykernel.comm.Comm class has been deprecated. Please use the comm module instead.For creating comms, use the function from comm import create_comm.

e.g. https://github.com/dask/distributed/actions/runs/4473742414/jobs/7861483350?pr=7686

Activity

  1. crusaderky commented on Mar 22, 2023

    @crusaderky
    CollaboratorAuthor

    This morning the failure changed and the whole CI is now red:

    ________ ERROR collecting distributed/diagnostics/tests/test_widgets.py ________
    distributed/diagnostics/tests/test_widgets.py:18: in
    from ipykernel.comm import Comm
    /usr/share/miniconda3/envs/dask-distributed/lib/python3.8/site-packages/ipykernel/init.py:5: in
    from .connect import * # noqa
    /usr/share/miniconda3/envs/dask-distributed/lib/python3.8/site-packages/ipykernel/connect.py:11: in
    import jupyter_client
    /usr/share/miniconda3/envs/dask-distributed/lib/python3.8/site-packages/jupyter_client/init.py:8: in
    from .asynchronous import AsyncKernelClient # noqa
    /usr/share/miniconda3/envs/dask-distributed/lib/python3.8/site-packages/jupyter_client/asynchronous/init.py:1: in
    from .client import AsyncKernelClient # noqa
    /usr/share/miniconda3/envs/dask-distributed/lib/python3.8/site-packages/jupyter_client/asynchronous/client.py:9: in
    from ..client import KernelClient, reqrep
    /usr/share/miniconda3/envs/dask-distributed/lib/python3.8/site-packages/jupyter_client/client.py:20: in
    from .connect import ConnectionFileMixin
    /usr/share/miniconda3/envs/dask-distributed/lib/python3.8/site-packages/jupyter_client/connect.py:20: in
    from jupyter_core.paths import jupyter_data_dir, jupyter_runtime_dir, secure_write
    /usr/share/miniconda3/envs/dask-distributed/lib/python3.8/site-packages/jupyter_core/paths.py:208: in
    deprecation(
    /usr/share/miniconda3/envs/dask-distributed/lib/python3.8/site-packages/jupyter_core/utils/init.py:89: in deprecation
    warnings.warn(message, DeprecationWarning, stacklevel=stacklevel + 1)
    E DeprecationWarning: Jupyter is migrating its paths to use standard platformdirs
    E given by the platformdirs library. To remove this warning and
    E see the appropriate new directories, set the environment variable
    E JUPYTER_PLATFORM_DIRS=1 and then run jupyter --paths.
    E The use of platformdirs will be the default in jupyter_core v6

  2. crusaderky commented on Mar 22, 2023

    @crusaderky
    CollaboratorAuthor

    We've temporarily plugged the issue with #7689 + #7693.
    However, gpuCI is failing with the same message.
    @charlesbluca I couldn't find where the conda requirements file is for it; it looks like a pre-built docker image?

  3. charlesbluca commented on Mar 22, 2023

    @charlesbluca
    Member

    it looks like a pre-built docker image?

    Yeah, the image is being built with the 3.8/3.10 environments from this repo, patched with some RAPIDS dependencies. Once this PR is merged in, we can rebuild the images to reflect the changes made in the environment.

    Or, if you'd like to make a change reflected directly in this PR, you can add a mamba install to this script:

    https://github.com/dask/distributed/blob/main/continuous_integration/gpuci/build.sh

    Which is what is run for the gpuCI test build.

  4. jrbourbeau commented on Mar 22, 2023

    @jrbourbeau
    Member

    Just following up here. It looks like the two needed PRs are in. @charlesbluca could you launch an image rebuild whenever you get a moment?

  5. charlesbluca commented on Mar 22, 2023

    @charlesbluca
    Member

    Yup, just triggered a rebuild

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions