Skip to content

Pass stimulus_id to SchedulerPlugin hooks #7973

Description

@hendrikmakait

To be able to automatically restart P2P shuffles, we need some notion of a transaction in the plugin hooks (#7970). This can be implemented by optionally passing an existing stimulus_id to the SchedulerPlugin.transition and SchedulerPlugin.remove_worker hooks.

This would also generally be helpful to track lineage in the plugin hooks. As this is a breaking change to the public API of the SchedulerPlugin, I'm torn between adding the stimulus_id to all hooks once and just making the necessary changes to unblock #7970.

Activity

  1. added
    enhancementImprove existing functionality or make things work better
    on Jul 6, 2023
  2. hendrikmakait commented on Jul 24, 2023

    @hendrikmakait
    MemberAuthor

    Partially completed by #7974. This can be reopened if the need for stimulus_id in other hooks arises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementImprove existing functionality or make things work better

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions