Skip to content

Fix Client.register_plugin inferred as NoReturn - #9201

Merged
jacobtomlinson merged 1 commit into
dask:mainfrom
moi90:fix-no-return
Mar 3, 2026
Merged

jacobtomlinson merged 1 commit into
dask:mainfrom
moi90:fix-no-return

Conversation

@moi90

@moi90 moi90 commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

Closes #9176

  • Tests added / passed
  • Passes pre-commit run --all-files

@moi90
moi90 requested a review from fjetter as a code owner March 3, 2026 13:53
@moi90 moi90 changed the title Fix no return Fix Client.register_plugin inferred as NoReturn (#9176) Mar 3, 2026
@moi90 moi90 changed the title Fix Client.register_plugin inferred as NoReturn (#9176) Fix Client.register_plugin inferred as NoReturn Mar 3, 2026

@jacobtomlinson jacobtomlinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at this. One small question

Comment thread distributed/client.py
@jacobtomlinson
jacobtomlinson merged commit 5e46e5e into dask:main Mar 3, 2026
32 of 37 checks passed
@moi90
moi90 deleted the fix-no-return branch March 3, 2026 17:59
@moi90

moi90 commented Mar 3, 2026

Copy link
Copy Markdown
Contributor Author

Nice! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Client.register_plugin inferred as NoReturn

2 participants