Repository navigation
setproctitle: avoid being caught by dask.config; add to test envs - #9202
Merged
Merged
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 31 files ±0 31 suites ±0 11h 17m 47s ⏱️ - 5m 24s For more details on these failures, see this check. Results for commit 92ee382. ± Comparison against base commit 5e46e5e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
proctitle is a subsystem added 8 years ago and then forgotten by all.
It is always on if the necessary dependency is installed.
As the dependency was not installed in any test environment, it went quietly untested.
This PR adds it to the test envs.
Also fix an issue where
dask.config.refreshwould accidentally pick up aprocesskey due to a collision with the naming convention of dask env variables (this is why I stumbled on this module, btw).