Move state validation from Scheduler to SchedulerState by crusaderky · Pull Request #9224 · dask/distributed

crusaderky · 2026-04-28T11:59:35Z

99.9% of scheduler state validation belongs to the SchedulerState.
This PR also cleans up a downcast antipattern from SchedulerState to Scheduler.

crusaderky · 2026-04-28T12:00:03Z


        return msg

+    ###################


These methods have been copied verbatim, with the exception of two rows in validate_state (see below)

crusaderky · 2026-04-28T12:01:26Z

        if not (set(self.workers) == set(self.stream_comms)):
            raise ValueError("Workers not the same in all collections")


These two lines is the only bit of state validation that is not exclusive to the SchedulerState

Move state validation from Scheduler to SchedulerState

6570afb

crusaderky requested a review from fjetter as a code owner April 28, 2026 11:59

crusaderky commented Apr 28, 2026

View reviewed changes

crusaderky merged commit 30ecf55 into dask:main Apr 28, 2026
34 of 37 checks passed

crusaderky deleted the validate-scheduler branch April 28, 2026 13:51

Navigation Menu

		if not (set(self.workers) == set(self.stream_comms)):
		raise ValueError("Workers not the same in all collections")