Repository navigation
Clarify scheduler unpickling in protocol docs - #9286
Merged
crusaderky merged 1 commit intoJun 5, 2026
Merged
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 40 files + 1 40 suites +1 14h 17m 56s ⏱️ + 9m 16s For more details on these failures, see this check. Results for commit 7cf6f7e. ± Comparison against base commit ac18195. ♻️ This comment has been updated with latest results. |
peter941221
marked this pull request as ready for review
June 4, 2026 22:59
peter941221
force-pushed
the
docs/issue-9283-protocol-unpickle
branch
2 times, most recently
from
June 5, 2026 01:54
60c0a81 to
57d198d
Compare
peter941221
force-pushed
the
docs/issue-9283-protocol-unpickle
branch
from
June 5, 2026 02:36
57d198d to
7cf6f7e
Compare
crusaderky
approved these changes
Jun 5, 2026
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9283.
protocol.rstsaid the scheduler kept pickled functions as bytes and was protected from unsafe unpickling.That did not match the current implementation.
ToPicklesays the scheduler unpickles on arrival,distributed.protocol.core.loads()unpickles__Pickled__frames, and the client usesToPicklefor control-plane fields such ascode,annotations, andspan_metadata.This patch narrows the claim. The docs now explain that the scheduler can forward
Serializedtask payloads without deserializing them when decoding withdeserialize=False, but it still unpicklesToPicklecontrol-plane fields.The updated text also makes the trust boundary explicit and points readers at
distributed.comm.require-encryptionfor TLS.