Repository navigation
Add PyPI release workflow - #9297
Conversation
crusaderky
left a comment
crusaderky
left a comment
There was a problem hiding this comment.
Thanks for the PR! It mostly looks good. A few notes below.
| release_version="$RELEASE_VERSION" | ||
| if [[ ! "$release_version" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then | ||
| echo "::error::Release versions must use x.x.x form, got $release_version" |
There was a problem hiding this comment.
| release_version="$RELEASE_VERSION" | |
| if [[ ! "$release_version" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then | |
| echo "::error::Release versions must use x.x.x form, got $release_version" | |
| if [[ ! "$RELEASE_VERSION" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then | |
| echo "::error::Release versions must use x.x.x form, got $RELEASE_VERSION" |
| dask_version="$DASK_VERSION_TO_WAIT_FOR" | ||
| if [[ ! "$dask_version" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then | ||
| echo "::error::Dask versions must use x.x.x form, got $dask_version" |
There was a problem hiding this comment.
| dask_version="$DASK_VERSION_TO_WAIT_FOR" | |
| if [[ ! "$dask_version" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then | |
| echo "::error::Dask versions must use x.x.x form, got $dask_version" | |
| if [[ ! "$DASK_VERSION_TO_WAIT_FOR" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then | |
| echo "::error::Dask versions must use x.x.x form, got $DASK_VERSION_TO_WAIT_FOR" |
| export SETUPTOOLS_SCM_PRETEND_VERSION_FOR_DISTRIBUTED="$RELEASE_VERSION" | ||
| fi | ||
| uv build --sdist --wheel | ||
| - name: Check built versions |
There was a problem hiding this comment.
See my comment in the dask PR; this step feels quite overengineered
| enter the protected PyPI environment, upload to PyPI, or publish GitHub | ||
| Releases. | ||
|
|
||
| For coordinated Dask and Distributed releases, the Dask and Distributed tags may |
There was a problem hiding this comment.
| For coordinated Dask and Distributed releases, the Dask and Distributed tags may | |
| To save time, the Dask and Distributed tags may |
The wording may suggest that you can have one without the other, while you don't
| echo "::error::Dask versions must use x.x.x form, got $dask_version" | ||
| exit 1 | ||
| fi | ||
| - name: Build distributions |
There was a problem hiding this comment.
A think adding here a cheap grep 'dask >= DASK_VERSION_TO_WAIT_FOR pyproject.toml` will save a lot of time when the maintainer inevitably forgets to update the file.
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 40 files ±0 40 suites ±0 14h 31m 48s ⏱️ + 2m 47s For more details on these failures, see this check. Results for commit 49501df. ± Comparison against base commit 6e4ca76. |
crusaderky
left a comment
crusaderky
left a comment
There was a problem hiding this comment.
I have not tested it, but otherwise it looks good. Thank you!
2 participants
See dask/dask#12452