Repository navigation
fix(ext/node): handle multiple calls in inspector.Session.post() - #31067
Merged
Merged
Conversation
fraidev
force-pushed
the
fix_node_inspector_nested
branch
from
October 23, 2025 04:35
7734430 to
0a6de17
Compare
Contributor
|
Great work! What do you think if we move the queue to the JS side to make it less complex on the Rust side? I was thinking something like this: b258bb4 |
Member
|
I agree with @Tango992 here - seems to be much simpler to keep it in JS |
fraidev
force-pushed
the
fix_node_inspector_nested
branch
2 times, most recently
from
October 25, 2025 14:27
cb3b182 to
28c9eaf
Compare
fraidev
force-pushed
the
fix_node_inspector_nested
branch
from
October 25, 2025 14:44
28c9eaf to
b732423
Compare
Contributor
Author
Makes sense! I moved the queue to the JS side, and all tests are still passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a panic that occurred when using nested session.post() calls in the node:inspector module. The issue manifested when callbacks from inspector commands (like Profiler.enable) called session.post() again, causing a re-entrant invocation of op_inspector_dispatch.
The fix involves:
This ensures that:
Includes comprehensive tests for deep nesting, and queue ordering behavior.
Fixes #31020