Repository navigation
fix(ext/node): emit deprecation warning for SlowBuffer - #31772
Merged
fraidev merged 3 commits intoJan 10, 2026
Merged
Conversation
Member
|
Can you enable that test? |
fraidev
force-pushed
the
fix-slowbuffer-deprecation-warning
branch
from
January 9, 2026 17:50
caff41b to
7c8450d
Compare
Contributor
Author
Sure, done! |
bartlomieju
approved these changes
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the DEP0030 deprecation warning when SlowBuffer() is called, matching Node.js behavior.
This fixes the node_compat test parallel/test-buffer-slow.js.