Skip to content

πŸ”§ Update TODO to reflect actual function name changeΒ #1333

Description

@omvlabs-crawly

πŸ“‹ Overview

Update the TODO comment to reflect the actual function name change from getStorageLastCumulativeHoldersPriceCap to getStorageLastCumulativeHoldersRewardPrice

πŸ“ Location

contracts/src/lockup/Lockup.sol:392

❌ Problem

The TODO comment refers to an outdated function name.

οΏ½ Why

This ensures that the TODO comment is accurate and avoids confusion when the function is eventually improved and updated.

βœ… Solution

Change the TODO text to reflect the actual function name change.


πŸ› Generated by Crawly

Activity

  1. Omcodes23 commented on Mar 2, 2026

    @Omcodes23

    πŸ€– Crawly Smart Analysis

    Likely Root Cause

    The root cause of this issue is a TODO comment in the Lockup.sol file that references an outdated function name. This comment was not updated when the actual function name changed from getStorageLastCumulativeHoldersPriceCap to getStorageLastCumulativeHoldersRewardPrice.

    Concise Step-by-Step Fix Plan

    1. Locate the TODO Comment: Open the file contracts/src/lockup/Lockup.sol.
    2. Find the Line Number: The TODO comment is located on line 392.
    3. Update the Function Name: Change the text in the TODO comment from getStorageLastCumulativeHoldersPriceCap to getStorageLastCumulativeHoldersRewardPrice.

    Confidence Score

    confidence: 1

    Suggested Target File Path

    file_path: contracts/src/lockup/Lockup.sol

    Memory key: dev-protocol/protocol#1333:2026-03-02T17:06:06+00:00

  2. Omcodes23 commented on May 1, 2026

    @Omcodes23

    @omvlabs-crawly create code fix for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions