🤖 Generated by the Daily AI Assistant
Problem
The gitops-repo-audit skill bundles three non-trivial Bash helper scripts that ship to users but have zero test coverage — there is no .test.sh alongside any of them, and CI never executes them:
The repo's only script test is the root-level scripts/validate-manifests.test.sh (added in #26), which the CI lint-scripts job runs. The skill-bundled scripts are outside that job's scope, so a regression in any of them — a broken exit code, a missed deprecation marker, an arg-parsing change — would land green and reach users.
This is the last remaining gap in the "every guard/helper script gets a hermetic self-test" holistic thread (previously delivered for validate-manifests.sh #26, plus run-mockery, rename-placeholders, check-readme-index, is-superseded, check-upstream-skills across the suite).
Proposed direction
Mirror the established *.test.sh pattern (hermetic: no network, no real flux/git/kubeconform — stub each required binary on PATH, like the offline gh-stub idiom used for check-upstream-skills.test.sh):
- Add
check-deprecated.test.sh — assert the four error paths (missing -d, non-existent dir, missing flux CLI, usage on -h) and the deprecation exit-code contract (stub flux to emit output with vs. without ✚/-> → exit 1 vs 0).
- Add
discover.test.sh and validate.test.sh covering their core logic against fixture repos with stubbed external tools.
- Extend the CI
lint-scripts job to discover and run *.test.sh under plugins/**/skills/**/scripts/ (not just the repo root), so future bundled scripts are auto-covered.
Tests must pin real behaviour and edge cases — no vacuous assertions, no weakening to make them pass.
Rough size
Small–medium. check-deprecated.test.sh is a clean first installment (~47-line script, pure arg/exit-code logic); discover.sh/validate.sh need fixture repos + more stubs. Can ship incrementally (one script-test per PR) or as one PR; the CI-job extension is a few lines.
Problem
The
gitops-repo-auditskill bundles three non-trivial Bash helper scripts that ship to users but have zero test coverage — there is no.test.shalongside any of them, and CI never executes them:plugins/gitops-kubernetes/skills/gitops-repo-audit/scripts/check-deprecated.sh(~47 lines) — arg parsing, dir/flux pre-flight checks, and agrep -qE "✚|->"-based deprecation-detection exit code overflux migrate --dry-runoutput.plugins/gitops-kubernetes/skills/gitops-repo-audit/scripts/discover.sh(~151 lines) — git/awk discovery logic.plugins/gitops-kubernetes/skills/gitops-repo-audit/scripts/validate.sh(~229 lines) — validation orchestration.The repo's only script test is the root-level
scripts/validate-manifests.test.sh(added in #26), which the CIlint-scriptsjob runs. The skill-bundled scripts are outside that job's scope, so a regression in any of them — a broken exit code, a missed deprecation marker, an arg-parsing change — would land green and reach users.This is the last remaining gap in the "every guard/helper script gets a hermetic self-test" holistic thread (previously delivered for
validate-manifests.sh#26, plusrun-mockery,rename-placeholders,check-readme-index,is-superseded,check-upstream-skillsacross the suite).Proposed direction
Mirror the established
*.test.shpattern (hermetic: no network, no realflux/git/kubeconform— stub each required binary onPATH, like the offlinegh-stub idiom used forcheck-upstream-skills.test.sh):check-deprecated.test.sh— assert the four error paths (missing-d, non-existent dir, missingfluxCLI, usage on-h) and the deprecation exit-code contract (stubfluxto emit output with vs. without✚/->→ exit 1 vs 0).discover.test.shandvalidate.test.shcovering their core logic against fixture repos with stubbed external tools.lint-scriptsjob to discover and run*.test.shunderplugins/**/skills/**/scripts/(not just the repo root), so future bundled scripts are auto-covered.Tests must pin real behaviour and edge cases — no vacuous assertions, no weakening to make them pass.
Rough size
Small–medium.
check-deprecated.test.shis a clean first installment (~47-line script, pure arg/exit-code logic);discover.sh/validate.shneed fixture repos + more stubs. Can ship incrementally (one script-test per PR) or as one PR; the CI-job extension is a few lines.