Support for other Scala versions #579

Activity

1. nedtwigg commented on May 18, 2020

   

   nedtwigg

   on May 18, 2020

   Member

   More actions

   Would be happy to merge and release a PR for this!

   Besides the place you pointed out, the other affected locations are:

   • https://github.com/diffplug/spotless/blob/master/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/ScalaExtension.java
   • https://github.com/diffplug/spotless/blob/master/plugin-maven/src/main/java/com/diffplug/spotless/maven/scala/Scala.java

   ScalaFmtStep probably needs to add a versionScala parameter, and ideally that could be autopopulated by the gradle and maven plugins by slurping it from the build context, but it's alright if that's not possible.
2. nedtwigg

   added

   enhancement

   on May 18, 2020
3. hnoson commented on May 19, 2020

   

   hnoson

   on May 19, 2020

   Author

   More actions

   I realized that the version doesn't matter as long as it's used from Java because the version suffix is for binary compatibility. The formatting functionality doesn't change depending on the Scala version. Please close this issue if there is no concern.
4. nedtwigg commented on May 19, 2020

   

   nedtwigg

   on May 19, 2020

   Member

   More actions

   Thanks, useful to know!
5. nedtwigg

   closed this as completedon May 19, 2020
6. nedtwigg

   removed

   enhancement

   on May 19, 2020