Skip to content

Fix GrEclipse initialization warnings - #3097

Merged
nedtwigg merged 3 commits into
diffplug:mainfrom
wborn:fix/greclipse-warnings
Sep 25, 2026
Merged

nedtwigg merged 3 commits into
diffplug:mainfrom
wborn:fix/greclipse-warnings

Conversation

@wborn

@wborn wborn commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Summary

GrEclipse initialization currently emits several warnings even though formatting succeeds.

This change:

  • uses the nested-jar directory from the formatter classpath instead of falling back to Equo's default cache location
  • removes the obsolete groovy-test exclusion added as a workaround for Fix NoSuchElementException if package is not exported equodev/equo-ide#193, which is fixed in the Solstice version used by Spotless
  • configures osgi.configuration.area for the embedded Eclipse runtime
  • routes expected Solstice missing bundle/capability diagnostics through SLF4J at INFO level instead of WARN

This removes warnings such as:

The following nested jars are missing from ...
Missing required bundle org.eclipse.jdt.debug ...
Missing required capability ...
Recommend setting osgi.configuration.area to a directory ...

The Groovy-Eclipse compiler resolver output is not addressed by this change because it is written directly to System.out by Groovy-Eclipse.

Tested with:

./gradlew :lib-extra:test --tests com.diffplug.spotless.extra.groovy.GrEclipseFormatterStepTest
./gradlew :plugin-maven:test --tests com.diffplug.spotless.maven.groovy.GrEclipseTest
./gradlew :plugin-gradle:test

Fixes #2445

Use the nested-jar directory from the formatter classpath instead of falling back to Equo's default cache location.

Remove the obsolete groovy-test exclusion now that equo-ide#193 is fixed, configure an OSGi configuration area, and route expected Solstice manifest diagnostics through SLF4J at INFO level.

Fixes diffplug#2445
@wborn

wborn commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

The Groovy-Eclipse compiler resolver output is not addressed by this change because it is written directly to System.out by Groovy-Eclipse.

I created groovy/groovy-eclipse#1703 to address this.

@nedtwigg
nedtwigg enabled auto-merge September 25, 2026 18:40
@nedtwigg
nedtwigg merged commit bbf44a4 into diffplug:main Sep 25, 2026
18 checks passed
@wborn
wborn deleted the fix/greclipse-warnings branch September 26, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing required bundle and Missing required capability

2 participants