Repository navigation
Avoid redundant TypeScript Prettier parser warning - #3098
Merged
nedtwigg merged 2 commits intoSep 25, 2026
Merged
Conversation
Do not warn when the Prettier parser is already set to `typescript`. Continue warning when a different parser is overridden. Add tests for both cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TypeScript Prettier configuration always sets the parser to
typescript.When subsequent configuration methods recreate the formatter step, the parser is already set to
typescript, causing Spotless to emit a misleading warning:Avoid emitting the warning when the parser is already
typescript, while preserving the warning when a different parser is actually overridden.Tests cover both cases:
typescriptbabel