Skip to content

feat: introduce aws to minectl - #210

Merged
dirien merged 1 commit into
dirien:mainfrom
cpanato:add-aws
Oct 6, 2021
Merged

feat: introduce aws to minectl#210
dirien merged 1 commit into
dirien:mainfrom
cpanato:add-aws

Conversation

@cpanato

@cpanato cpanato commented Sep 26, 2021

Copy link
Copy Markdown
Contributor

Add initial implemenation for AWS provider

$ ./bin/minectl-darwin create --filename minetest.yaml
🛎 Using cloud provider Amazon WebServices
🗺 Minecraft java edition
🏗  Creating server (minecraft-server)...
error determining if the running executable was installed with brew: 'brew --prefix minectl' failed: exit status 1✅ Server (minecraft-server) created.
🕹 Starting Minecraft server...
🕹 Starting Minecraft server...
✅ Minecraft server successfully started.

          ID          |       NAME       |  REGION   |                TAGS                |      IP
----------------------+------------------+-----------+------------------------------------+----------------
  i-0f09ebd0c9c65902f | minecraft-server | us-west-1 | minectl=true,Name=minecraft-server | 54.176.89.235

🪓 To delete the server type:

 minectl delete -f minetest.yaml --id i-0f09ebd0c9c65902f


🆙 To update the server type:

 minectl update -f minetest.yaml --id i-0f09ebd0c9c65902f

🚧 Beta features:
⤴️ To upload a plugin type:

 minectl plugins -f minetest.yaml --id i-0f09ebd0c9c65902f --plugin <folder>/x.jar --destination /minecraft/plugins


🔌 Connected to RCON type:

 minectl rcon -f minetest.yaml --id i-0f09ebd0c9c65902f

future work:

  • define custom VPC/subnet

@cpanato
cpanato requested a review from dirien as a code owner September 26, 2021 13:12
@cpanato cpanato changed the title aws: introduce aws to minectl feat: introduce aws to minectl Sep 26, 2021
@cpanato

cpanato commented Sep 26, 2021

Copy link
Copy Markdown
Contributor Author

List:

$ ./bin/minectl-darwin  list --provider aws --region us-west-1
📒 List all server
🛎 Using cloud provider Amazon WebServices

          ID          |       NAME       |  REGION   |                TAGS                |      IP
----------------------+------------------+-----------+------------------------------------+----------------
  i-0f09ebd0c9c65902f | minecraft-server | us-west-1 | minectl=true,Name=minecraft-server | 54.176.89.235

@cpanato

cpanato commented Sep 26, 2021

Copy link
Copy Markdown
Contributor Author

Delete:

$ ./bin/minectl-darwin delete -f minetest.yaml --id i-0f09ebd0c9c65902f
🛎 Using cloud provider Amazon WebServices
🗺 Minecraft java edition
🪓 Deleting server (minecraft-server)...
error determining if the running executable was installed with brew: 'brew --prefix minectl' failed: exit status 1
🪓 Deleting server (minecraft-server)...
🪓 Deleting server (minecraft-server)...
🗑 Server (minecraft-server) deleted.

dirien
dirien requested changes Sep 27, 2021
View reviewed changes

@dirien dirien left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cpanato, huge thanks for this work! ❤️

Just some small comments,

But could you update the README.md file to:

  • A AWS badge
  • The Credendtials part
  • And an example config file in the config folder for whatever Server edition you want

Comment thread pkg/provisioner/provisioner.go
Comment thread pkg/template/templates/cloud-init/cloud-config.yaml.tmpl
Comment thread pkg/template/templates/cloud-init/cloud-config.yaml.tmpl
Comment thread pkg/template/templates/cloud-init/cloud-config.yaml.tmpl
@cpanato
cpanato requested a review from dirien September 28, 2021 11:00
dirien
dirien requested changes Sep 28, 2021
View reviewed changes

@dirien dirien left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor things, and could you submitt your config file two? So we have this as an example!

Thank you so much!

Comment thread README.md Outdated
Comment thread README.md
@cpanato
cpanato requested a review from dirien September 29, 2021 08:42
dirien
dirien requested changes Sep 29, 2021
View reviewed changes

@dirien dirien left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

i added the UDP / TCP Support for bedrock server and Monitoring and Rcon support.

I hope its okay? I have the code here if its easier to than my suggestions..

Other then that it works really well! Thanks!

Comment thread pkg/cloud/aws/aws.go Outdated
Comment thread pkg/cloud/aws/aws.go Outdated
Comment thread pkg/cloud/aws/aws.go Outdated
Comment thread pkg/cloud/aws/aws.go Outdated
Comment thread pkg/cloud/aws/aws.go Outdated
Comment thread pkg/cloud/aws/aws.go
@cpanato
feat: introduce aws to minectl
3527ebe 
Signed-off-by: Carlos Panato <[email protected]>
@dirien

dirien commented Oct 6, 2021

Copy link
Copy Markdown
Owner

There is a merge conflict, but i will fix this! Thanks @cpanato for this huge help!

@dirien
dirien merged commit 1b233fd into dirien:main Oct 6, 2021
@dirien dirien mentioned this pull request Oct 6, 2021
Merged
@dirien dirien linked an issue Oct 6, 2021 that may be closed by this pull request
New cloud provider - EC2 #57
Closed
@cpanato
cpanato deleted the add-aws branch October 7, 2021 07:17
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dirien dirien dirien requested changes

Assignees

No one assigned

Labels

hacktoberfest-accepted size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New cloud provider - EC2

2 participants

@cpanato @dirien