Repository navigation
Switch to using maybeLocaleOf instead of localeOf - #443
Conversation
|
cc @dnfield |
|
Hm. Looks like dart changed some rules. I can push a fix up for it and then merge it into this. |
353b706 to
8ec21fb
Compare
|
Now coveralls is failing? :\ |
|
|
|
I just rebased and pushed. This isn't expected to pass though, until the next dev release, since the requested SDK version doesn't exist yet. |
|
I can switch this to a draft PR until then, if you want. |
|
Yeah let's do that, as long as it doesn't block progress upstream. |
8ec21fb to
fceb0c2
Compare
5762a0f to
421514e
Compare
|
Hmm. I tried re-running this now that 1.24.0-10.2.pre is out in dev (and beta), and it fails on Stable. Is that expected? It also still fails coveralls, but that seems like a CI problem. |
421514e to
764523e
Compare
|
OK, @dnfield trying again now that the pubspec has advanced the Flutter version. |
|
OK, so maybe I just need to make this change on the nullsafety branch? Seems like the master branch for |
|
Coveralls is sometimes failing for reasons I don't understand, this change LGTM and should be fine to land as is. |
See discussion at flutter/flutter#68911
Obv, 1.24.0-8.0.pre hasn't been released yet, but will include the appropriate change when it has been.