Repository navigation
Add --resolve-image-digests option to docker-compose config command - #4333
Conversation
9b3b85f to
32af4be
Compare
|
cc @dnephin for your thoughts - not sure if this was disccused before. |
|
I don't know of any previous discussion about this, but it seems like a good idea to me. It's effectively a "pin the image" feature, which I think is good. On the implementation, I think there is a lot of duplicated code. Can you have it share the code with |
|
Sure, I can work on refactoring the digests code between Does |
|
In the context of |
7ac78be to
01e7972
Compare
kinghuang
changed the title
7767a7a to
cea5f7e
Compare
|
The option has been renamed to |
Add arguments for image digests in the config.serialize module to optionally pin images to digests, like bundles. Signed-off-by: King Chung Huang <[email protected]>
Add a --resolve-image-digests argument to the config command that pins images to a specific image digest, just like the bundle command. This can be used to pin images in compose files being used to deploy stacks in Docker 1.13. Signed-off-by: King Chung Huang <[email protected]>
Add two unit tests to validate that the denormalize_service_dict function still works without passing a third argument for image_digest, and correctly uses an image digest if one is provided. Signed-off-by: King Chung Huang <[email protected]>
Extract the code in bundle() and config() that translates image tags into digests into a function named image_digests_for_project(). Signed-off-by: King Chung Huang <[email protected]>
cea5f7e to
962ba5b
Compare
|
@shin- What's the process for getting this into a release? |
|
I still need to take a closer look at it, but tentatively adding to the 1.12 milestone Thanks for reminding me 👍 |
4 participants
Add an option named
--digestto thedocker-compose configcommand. It pins images to specific image digests for compose files, just like thedocker-compose bundlecommand for DAB files.Resolves #4332.