Repository navigation
Resolve digests without pulling image - #6454
Merged
Merged
Conversation
shin-
reviewed
Jan 14, 2019
| raise UserError( | ||
| "Digest not found for service '{service}'. " | ||
| "Repository does not exist or may require 'docker login'" | ||
| .format(service=service.name, action=action)) |
There was a problem hiding this comment.
action isn't used here and can be removed
| "rebuild this image you must use `docker-compose build` or " | ||
| "`docker-compose up --build`.".format(self.name)) | ||
|
|
||
| def distribution(self): |
There was a problem hiding this comment.
I would go for a more explicit name here, like get_image_registry_data()
If there is no image locally `docker-compose --resolve-image-digests` will try and get the digest from the repository. Fixes docker#5818 Signed-off-by: Djordje Lukic <[email protected]>
rumpl
force-pushed
the
digest-distribution
branch
from
January 15, 2019 13:24
b2a6461 to
0c20fc5
Compare
chris-crone
approved these changes
Jan 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is no image locally
docker-compose --resolve-image-digestswill try and get the digest from the repository.
Signed-off-by: Djordje Lukic [email protected]
Resolves #5818