Repository navigation
fix: ctrl-k behavior on macOS - #2052
Merged
Merged
Conversation
Use cmd-k on macOS/iOS for search and keep ctrl-k everywhere else. Fixes a bug where ctrl-k on macOS, which cuts to the end of the line, was also triggering the search prompt.
|
|
|
Hi, Does this also need to be modified? |
Contributor
Author
Good catch. Changed there too. |
Member
|
Thanks for contributing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where on macOS ctrl-k does two things (1) cuts to the end of the line (2) triggers the search prompt. I changed it so that search is explicitly cmd-k on macOS/iOS and ctrl-k everywhere else, which fixes
ctrl-kon macOS.I also:
cmd-ksuggestion on Apple machinesctrl-s/cmd-sto be platform specific -- I don't thinkwin+s(Windows Search) would've made it to the browser anyways.Tested locally and it seemed to work as expected.
AI Notice: This PR was Claude Code assisted.