Repository navigation
fix(page-permission): make people-with-access list scroll past 4 entries - #2137
Merged
Philipinho merged 1 commit intoApr 29, 2026
Merged
Conversation
The "People with access" list in the page share modal used
<ScrollArea mah={250}>, which caps the container height but does not
make the inner viewport scroll (no fixed height is given to the
viewport). Items beyond ~4 entries were rendered correctly but clipped
out of view.
Switches to <ScrollArea.Autosize mah={400}>, which is Mantine's
dedicated primitive for "grow with content up to a max, then scroll".
Closes docmost#2135
Contributor
Author
|
Tested functionally and working. |
Member
|
Thanks for contributing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2135.
In the page share modal, the "People with access" list used
<ScrollArea mah={250}>.mahcaps the container height but does not make the inner viewport scroll on its own — Mantine'sScrollArearequires a fixed height for the viewport to scroll. The result: items beyond ~4 entries were rendered into the DOM correctly but clipped out of view, with no scrollbar.Fix
Switch to
<ScrollArea.Autosize mah={400}>, which is Mantine's dedicated primitive for "grow with content up to a max, then scroll" — exactly the behavior wanted here.Bumped the cap from 250px → 400px while we're here, since 250px is fairly tight (~4–5 rows) and pages with longer access lists are common.
Compare with
apps/client/src/features/space/components/space-members.tsxThat sibling list works correctly because it uses
<ScrollArea h={450}>(fixed height). Either pattern is valid;Autosizewas the better fit here because the access list is usually short and we don't want a tall empty box for pages with only 1–2 entries.Test plan