Repository navigation
fix: align input shortcuts - #2467
Merged
Merged
Conversation
salihudickson
requested review from
Philipinho
and
a lite review from Copilot
September 1, 2026 17:53
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the row detail modal’s field editing UX by tracking when a field is being edited and adjusting the footer keyboard hints, while also refactoring several field components to report “editing” state up to the modal.
Changes:
- Add
onEditingChangeplumbing fromRowDetailModal→PropertyRow→DetailField→ individual field components, toggled on focus/commit. - Update footer keyboard hint layout/content based on whether a field is currently being edited.
- Refactor
RowDetailTitlekeyboard handling to support “reset on Escape” via a cancel ref and commit-on-blur.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/client/src/ee/base/styles/row-detail-modal.module.css | Adjust keyboard hint layout and add group/plus styling helpers. |
| apps/client/src/ee/base/components/row-detail-modal/row-detail-title.tsx | Add editing-state reporting + cancel/reset flow on Escape and commit-on-blur refactor. |
| apps/client/src/ee/base/components/row-detail-modal/row-detail-modal.tsx | Track editingField state and render different keyboard hints while editing. |
| apps/client/src/ee/base/components/row-detail-modal/property-row.tsx | Pass onEditingChange down into the field renderer. |
| apps/client/src/ee/base/components/row-detail-modal/fields/field-text.tsx | Report editing state on focus/commit. |
| apps/client/src/ee/base/components/row-detail-modal/fields/field-number.tsx | Report editing state on focus/commit. |
| apps/client/src/ee/base/components/row-detail-modal/fields/field-long-text.tsx | Report editing state on focus/commit. |
| apps/client/src/ee/base/components/row-detail-modal/fields/detail-field.tsx | Extend shared FieldProps and pass onEditingChange into field components. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+375
to
+378
| <span className={classes.kbdGroup}> | ||
| <kbd className={classes.kbd}>Ctrl/Cmd</kbd> | ||
| <span>+</span> | ||
| <kbd className={classes.kbd}>Enter</kbd> |
salihudickson
marked this pull request as ready for review
September 1, 2026 19:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #2406