Tell self-hosters to set APP_URL, because email and connected-app links use it #337

Activity

1. HMarzban

   added

   DevOps

   Refactor

   on Sep 28, 2026
2. HMarzban commented on Sep 28, 2026

   

   HMarzban

   on Sep 28, 2026

   CollaboratorAuthor

   More actions

   Part of this issue is covered by two commits on main. They are committed locally and go up with the next push.

   Done

   • One clean APP_URL (cdb222d40, fix(hocuspocus): read APP_URL once, without a trailing slash).
     • config/env.ts now computes (env.APP_URL || 'https://docs.plus').replace(/\/+$/, '') once.
     • config.email.appUrl and the CORS fallback both use it. So a blank APP_URL= no longer gives '', and a trailing / is removed.
     • The email sender, the new-document notice and api/email.ts read config.email.appUrl instead of process.env.APP_URL. So the digest path through pgmqConsumer.ts gets the clean value too.
     • apps/hocuspocus.server/ENV.md describes the trim and the fallback.
   • MCP gets the app URL (0dacee392, feat(hocuspocus): add the create_document MCP tool).
     • MCP InitDeps and ServerFactoryDeps carry appUrl, and src/index.ts passes config.email.appUrl.
     • One tool output uses it already: the new create_document returns <appUrl>/<slug>. No existing tool output changed.

   Still open in this issue

   • The shared buildDocumentUrl / buildHeadingUrl helper, and deleting the digest's private sectionUrl. It is still in digestContentChanges.ts.
   • docs/self-hosting/configuration.md: telling operators to set APP_URL.
   • docs/self-hosting/install.md:66: the APP_URL row still says "used in email links" only.

   So acceptance items 3 and 4 are met. Items 1, 2, 6 and 7 remain.
3. HMarzban

   changed the title [-]Give the MCP module the app URL and one server heading-link helper[/-] [+]Tell self-hosters to set APP_URL, because email and connected-app links use it[/+] on Sep 29, 2026
4. HMarzban commented on Oct 7, 2026

   

   HMarzban

   on Oct 7, 2026

   CollaboratorAuthor

   More actions

   One more env value for this issue: PUBLIC_RESTAPI_URL also sets the MCP resource URL (apps/hocuspocus.server/src/index.ts:134, src/modules/mcp/http/controller.ts:23-24). When it is unset, the URL falls back to the request origin, so a self-hoster behind a proxy must set it. Please document it in apps/hocuspocus.server/ENV.md (which today says only two conversion paths read it) and in docs/self-hosting/configuration.md.