You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Check the share card Change link as the owner and scan its QR on a real phone #356
The desktop share card shows a QR code, a full-screen Present view, and an access line. The owner sees a Change link beside that line. Two checks never ran. Nobody clicked Change while signed in as the owner. Nobody scanned the QR with a real phone from a projected screen. This issue runs both checks and records the result.
Acceptance criteria
Signed in as the pad owner on desktop, the access line shows Change. A click closes the share card and opens the Document settings popover in the toolbar.
Signed in as a person who does not own the pad, the access line shows no Change. Signed out, it shows no Change.
The access line follows the pad state:
public pad that is not Read-only: "Anyone with the link can edit"
Read-only pad: "Anyone with the link can view"
Private pad: "Private. Only you can open it." The card shows no QR and no link.
An iPhone camera and an Android camera each open the pad from the in-card QR at arm's length.
Both phones open the pad from the Present view on a projected or large screen. Scan from the back of the room, in light and in dark Present.
Every scan opens the clean pad URL (origin/slug), with no ?h=, chat or Filter state, even when the address bar carried them.
The results are posted as a comment on this issue, with device, OS, distance and Present theme.
Blocked by
None — can start now.
Agent brief
Type: HITL — a person runs the checks. They need an owner account with a pad it owns, a second account, an iPhone, an Android phone, and a projector or large screen. They post the results on this issue and file a bug for any failure.
Category: enhancement
Current behavior: The share card is live on desktop (commit 6f48c654f). ShareModal.tsx:88-89 shows Change when the signed-in id equals ownerId and documentSettingsOpenRequest.canRequest() is true. canRequest() is true only while the desktop toolbar mounts documentSettingsOpenRequest.Listener (EditorToolbar.tsx:399). The QR and Copy carry the same clean URL (ShareModal.tsx:93-94).
Desired behavior: Both checks pass and are recorded. A failure becomes its own bug issue, with steps and a screenshot.
Where to start:apps/webapp/src/components/TipTap/pad-title-section/ShareModal.tsx (accessLines, canChangeAccess, openDocumentSettings). apps/webapp/src/components/TipTap/pad-title-section/PresentQrCode.tsx (Present view and its light/dark switch). apps/webapp/src/components/ui/QrCode.tsx. apps/webapp/src/components/TipTap/toolbar/desktop/popoverOpenRequest.tsx (documentSettingsOpenRequest). Line numbers are hints as of 2026-09-28; the agent searches by symbol.
Rules that apply:.cursor/docs/design-system.md §ShareModal holds the maintainer rulings of 2026-09-27. The card always shares the clean URL. No logo and no caption on the QR. The Present icon on the QR shows only on hover or focus. Dark Present dims the plate and never inverts the code. AGENTS.md §UI And Theme. CONTEXT.md §Document access defines Private, Read-only and Open document.
Verify: Use https://docs.plus, not a local run: a local QR carries localhost, which a phone cannot open. On desktop, open a pad the owner account owns. An Open document has no owner, so it never shows Change. Click Share in the pad title row.
As the owner: see Change, click it, and see the Document settings popover open. Repeat on a Read-only pad and a Private pad.
On a public pad, as a second account, then signed out: see no Change. Only the owner can open a Private pad.
Scan the in-card QR with each phone at arm's length, in the light and the dark app theme.
Click the QR to open Present. Project it. Scan from the back of the room, once in light and once in dark Present.
Click a heading in the TOC, so the address bar carries ?h=. Open Share and scan again. The phone must land on origin/slug.
Out of scope
Any change to the card layout, QR style or Present controls. Those are settled by the 2026-09-27 rulings in .cursor/docs/design-system.md §ShareModal.
The phone share path. The phone layout (MobileLayout.tsx, MobilePadTitle.tsx) mounts neither ShareModal nor the desktop toolbar.
Parent
#328.
What to build
The desktop share card shows a QR code, a full-screen Present view, and an access line. The owner sees a Change link beside that line. Two checks never ran. Nobody clicked Change while signed in as the owner. Nobody scanned the QR with a real phone from a projected screen. This issue runs both checks and records the result.
Acceptance criteria
origin/slug), with no?h=, chat or Filter state, even when the address bar carried them.Blocked by
None — can start now.
Agent brief
Type: HITL — a person runs the checks. They need an owner account with a pad it owns, a second account, an iPhone, an Android phone, and a projector or large screen. They post the results on this issue and file a bug for any failure.
Category: enhancement
Current behavior: The share card is live on desktop (commit
6f48c654f).ShareModal.tsx:88-89shows Change when the signed-in id equalsownerIdanddocumentSettingsOpenRequest.canRequest()is true.canRequest()is true only while the desktop toolbar mountsdocumentSettingsOpenRequest.Listener(EditorToolbar.tsx:399). The QR and Copy carry the same clean URL (ShareModal.tsx:93-94).Desired behavior: Both checks pass and are recorded. A failure becomes its own bug issue, with steps and a screenshot.
Where to start:
apps/webapp/src/components/TipTap/pad-title-section/ShareModal.tsx(accessLines,canChangeAccess,openDocumentSettings).apps/webapp/src/components/TipTap/pad-title-section/PresentQrCode.tsx(Present view and its light/dark switch).apps/webapp/src/components/ui/QrCode.tsx.apps/webapp/src/components/TipTap/toolbar/desktop/popoverOpenRequest.tsx(documentSettingsOpenRequest). Line numbers are hints as of 2026-09-28; the agent searches by symbol.Rules that apply:
.cursor/docs/design-system.md§ShareModal holds the maintainer rulings of 2026-09-27. The card always shares the clean URL. No logo and no caption on the QR. The Present icon on the QR shows only on hover or focus. Dark Present dims the plate and never inverts the code.AGENTS.md§UI And Theme.CONTEXT.md§Document access defines Private, Read-only and Open document.Verify: Use
https://docs.plus, not a local run: a local QR carrieslocalhost, which a phone cannot open. On desktop, open a pad the owner account owns. An Open document has no owner, so it never shows Change. Click Share in the pad title row.?h=. Open Share and scan again. The phone must land onorigin/slug.Out of scope
.cursor/docs/design-system.md§ShareModal.MobileLayout.tsx,MobilePadTitle.tsx) mounts neitherShareModalnor the desktop toolbar.