Repository navigation
fix(mcp): stop advertising tool list changes - #466
Open
legendteddy wants to merge 3 commits into
Open
legendteddy wants to merge 3 commits into
legendteddy wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stops the docs.plus MCP connector from advertising
tools.listChangedwhen its tool set is fixed.@modelcontextprotocol/[email protected]defaultstools.listChangedtotrue. Because docs.plus registers its document and chat tools once per request and never changes them afterward, newer MCP clients may otherwise open asubscriptions/listenstream that can never carry a tool-list notification.This change explicitly sets
capabilities: { tools: { listChanged: false } }when constructing theMcpServer, with a comment explaining why.Related issue
Closes #460
Type of change
How to test
Per #460:
apps/hocuspocus.server, runbun run typecheck && bun test.createServerFactorywith stub dependencies and inspectserver.server.getCapabilities().tools.{ listChanged: false }.Checklist
bun run check:ci(local replica of the prod quality gates).Local Bun execution was not available in the environment used to prepare this contribution, so the executable package checks are intentionally left unchecked rather than overstated.