Repository navigation
Properly fix DisplayMetrics.DENSITY_DEVICE_STABLE mapping #1084
Description
Activity
And someone needs to investigate why the PR build was green, which is why I think it's fine and it's merged.
enumification-helpers is fixed, and we have already discovered that api-compatibility didn't run inter-api-diff and therefore this kind of failure didn't get detected. And there is already 6dfba92 so nothing needs to be tracked from this issue anymore. Closing.
- added 2 commits that reference this issue
on Apr 18, 2020 - ghost locked as resolved and limited conversation to collaborators
on Jun 9, 2022
Commit ef77024 manually removed the
DisplayMetrics.DENSITY_DEVICE_STABLEenum binding, added by commit 50c0c15. This fix is incomplete/incorrect: the problem is that the underlying tooling inbuild-tools/enumification-helpersis doing "something" wrong, which means this invalid mapping will be reintroduced in the future.We need to fix
build-tools/enumification-helpersso thatDisplayMetrics.DENSITY_DEVICE_STABLEisn't reintroduced for enum mapping.