Issues Binding a library Library after AndroidX migration #4955

Activity

1. FANMixco

   added

   Area: BindingsIssues in Java Library Binding projects.Issues in Java Library Binding projects.

   on Jul 23, 2020
2. FANMixco

   assigned

   jpobst

   on Jul 23, 2020
3. jpobst commented on Jul 23, 2020

   

   jpobst

   on Jul 23, 2020

   Contributor

   More actions

   It seems like it is building fine, does it work? Warnings are pretty much a way of life when binding libraries. Generally they represent things the tooling could not automatically do. If you do not care about the API it could not bind automatically then you can ignore them. If you do need that API you will generally need to use "metadata" to help the tooling understand what to do:

   https://docs.microsoft.com/en-us/xamarin/android/platform/binding-java-library/customizing-bindings/java-bindings-metadata

   This one should be easy to fix by following the instructions:

   warning XA4231: The Android class parser value 'jar2xml' is deprecated and will be removed in a future version of Xamarin.Android. Update the project properties to use 'class-parse'.
   

   This one will probably go away when you switch to class-parse, as we only added Kotlin support to class-parse:

   warning J2XA006: missing class error was raised while reflecting com.dekoservidoni.omfm.OneMoreFabMenu : kotlin/jvm/internal/DefaultConstructorMarker
   

   This one is something we need to fix now that AndroidX breaks things down into tons of tiny packages:

   warning MSB6002: The command-line for the "BindingsGenerator" task is too long. Command-lines longer than 32000 characters are likely to fail. Try reducing the length of the command-line by breaking down the call to "BindingsGenerator" into multiple calls with fewer parameters per call.
   

   If you are referencing NuGet packages you do not need, removing them might make it go away.
4. grendello

   added this to the Under Consideration milestone on Jul 23, 2020
5. FANMixco commented on Jul 23, 2020

   

   FANMixco

   on Jul 23, 2020

   Author

   More actions

   It seems like it is building fine, does it work? Warnings are pretty much a way of life when binding libraries. Generally they represent things the tooling could not automatically do. If you do not care about the API it could not bind automatically then you can ignore them. If you do need that API you will generally need to use "metadata" to help the tooling understand what to do:

   https://docs.microsoft.com/en-us/xamarin/android/platform/binding-java-library/customizing-bindings/java-bindings-metadata

   This one should be easy to fix by following the instructions:

   warning XA4231: The Android class parser value 'jar2xml' is deprecated and will be removed in a future version of Xamarin.Android. Update the project properties to use 'class-parse'.
   

   This one will probably go away when you switch to class-parse, as we only added Kotlin support to class-parse:

   warning J2XA006: missing class error was raised while reflecting com.dekoservidoni.omfm.OneMoreFabMenu : kotlin/jvm/internal/DefaultConstructorMarker
   

   This one is something we need to fix now that AndroidX breaks things down into tons of tiny packages:

   warning MSB6002: The command-line for the "BindingsGenerator" task is too long. Command-lines longer than 32000 characters are likely to fail. Try reducing the length of the command-line by breaking down the call to "BindingsGenerator" into multiple calls with fewer parameters per call.
   

   If you are referencing NuGet packages you do not need, removing them might make it go away.

   Hi, the number one is tricky because I chose this option because the class-parse option doesn't give you any hint about the potential issues. I'd expand the class-parse before deprecating it.

   The ones I chose are because they exist in the original project that I upgraded and I'm almost convinced they're required because it's not the first library I have bound.

   I guess I'm missing one library or something should be extended, any hint?
6. jpobst commented on Jul 23, 2020

   

   jpobst

   on Jul 23, 2020

   Contributor

   More actions

   What potential issues are you referring to for class-parse? jar2xml has been deprecated for several years now, and the default for new binding projects has been class-parse for several years as well.
7. FANMixco commented on Jul 23, 2020

   

   FANMixco

   on Jul 23, 2020

   Last edited by FANMixco

   Author

   More actions

   What potential issues are you referring to for class-parse? jar2xml has been deprecated for several years now, and the default for new binding projects has been class-parse for several years as well.

   This is the result of the class-parse:

   1>------ Rebuild All started: Project: Xamarin-OneMoreFabMenu, Configuration: Release Any CPU ------
   1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\MSBuild\Xamarin\Android\Xamarin.Android.Bindings.targets(327,5): warning MSB6002: The command-line for the "BindingsGenerator" task is too long. Command-lines longer than 32000 characters are likely to fail. Try reducing the length of the command-line by breaking down the call to "BindingsGenerator" into multiple calls with fewer parameters per call.
   1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\MSBuild\Xamarin\Android\Xamarin.Android.Bindings.targets(372,5): warning MSB6002: The command-line for the "BindingsGenerator" task is too long. Command-lines longer than 32000 characters are likely to fail. Try reducing the length of the command-line by breaking down the call to "BindingsGenerator" into multiple calls with fewer parameters per call.
   1>BINDINGSGENERATOR : warning BG8604: top ancestor OneMoreFabUtils not found for nested type Com.Dekoservidoni.Omfm.Utils.OneMoreFabUtils.Direction.
   1>  Xamarin-OneMoreFabMenu -> C:\Users\feder\source\repos\Xamarin-OneMoreFabMenu\Xamarin-OneMoreFabMenu\bin\Release\Xamarin-OneMoreFabMenu.dll
   ========== Rebuild All: 1 succeeded, 0 failed, 0 skipped ==========
   

   It's very unclear about the issue, the java2xml is way more descriptive of where potentially is the issue. I don't use it for the final release, but to track where the issue can be.
8. jpobst commented on Jul 23, 2020

   

   jpobst

   on Jul 23, 2020

   Contributor

   More actions

   The warning produced by class-parse is completely different than the ones produced by jar2xml. Fixing one will not fix the other.

   This is because they use completely different mechanisms for reading the .jar file to determine what to bind.

   The class-parse warning is having an issue with binding Com.Dekoservidoni.Omfm.Utils.OneMoreFabUtils.Direction. Since this enum does not seem to be used anywhere, I would suggest ignoring the warning.
9. FANMixco commented on Jul 24, 2020

   

   FANMixco

   on Jul 24, 2020

   Last edited by FANMixco

   Author

   More actions

   The warning produced by class-parse is completely different than the ones produced by jar2xml. Fixing one will not fix the other.

   This is because they use completely different mechanisms for reading the .jar file to determine what to bind.

   The class-parse warning is having an issue with binding Com.Dekoservidoni.Omfm.Utils.OneMoreFabUtils.Direction. Since this enum does not seem to be used anywhere, I would suggest ignoring the warning.

   I don't think so because they're used in the main class OneMoreFabMenu:

   Between line 140 and 153:

   

   Line 346:

   

   I have noticed very strange behaviors with Enums in general since it's not the first time that I have faced something similar.
10. jpobst commented on Jul 24, 2020

    

    jpobst

    on Jul 24, 2020

    Contributor

    More actions

    While the Direction enum is used within the library, it is not publicly exposed. It is defined here, as a public enum inside an internal class:

    https://github.com/SupernovaIC/OMFM/blob/master/omfm/src/main/java/com/dekoservidoni/omfm/utils/OneMoreFabUtils.kt#L8

    The issue is we are ignoring the OneMoreFabUtils class because it is internal, but we are not ignoring the Direction enum like we should. Then when we are building our model of the types we try to nest the enum in the class, but we cannot find the class because we ignored it.

    The easiest way to remove the warning is to simply remove the Direction enum as it is not intended to be public and not needed by the binding:

    <remove-node path="/api/package[@name='com.dekoservidoni.omfm.utils']/class[@name='OneMoreFabUtils.Direction']" />
    
11. jpobst commented on Jul 24, 2020

    

    jpobst

    on Jul 24, 2020

    Contributor

    More actions

    Filed fixing the warning as dotnet/java-interop#682.
12. jpobst commented on Aug 17, 2020

    

    jpobst

    on Aug 17, 2020

    Contributor

    More actions

    Hopefully this got you unstuck! Closing this in favor of dotnet/java-interop#682.
13. jpobst

    closed this as completedon Aug 17, 2020
14. jonpryor

    added 2 commits that reference this issue on Sep 18, 2020

    [Xamarin.Android.Tools.Bytecode] Hide Kotlin nested types inside (#723)

    ...

    5136ef9

    [Xamarin.Android.Tools.Bytecode] Hide Kotlin nested types inside (#723)

    ...

    1a19ec0
15. ghost locked as resolved and limited conversation to collaborators on Jun 4, 2022