Skip to content

Review reflection usage in src/Mono.Android.Export/CallbackCode.cs #5206

Closed
Closed
Review reflection usage in src/Mono.Android.Export/CallbackCode.cs#5206
Labels
Area: TrimmingIssues with ILLink or NativeAOT related to trimming.
Milestone
.NET 8

Description

@radekdoulik
radekdoulik
opened on Oct 14, 2020

We are preserving many types unconditinally in Mono.Android.xml because of reflection used here.

It should be possible to remove some of the types from the list as illink is smarter about reflection and hopefully also update some of the code to be more linker friendly.

Also use the new dependency attributes when possible.

Activity

  1. radekdoulik
    added
    Area: TrimmingIssues with ILLink or NativeAOT related to trimming.
    on Oct 14, 2020
  2. radekdoulik
    added this to the One .NET milestone on Oct 14, 2020
  3. radekdoulik
    self-assigned this
    on Oct 14, 2020
  4. radekdoulik
    added 2 commits that reference this issue on Dec 22, 2020

    [illink] Do not preserve whole collection types

    56f7474

    [illink] Do not preserve IO stream adapter/invoker

    2f374a1
  5. jonpryor
    added 2 commits that reference this issue on Jan 4, 2021

    [One .NET] Do not preserve IO stream adapter/invoker (#5449)

    051cad7

    [One .NET] Do not preserve entire collection types (#5445)

    15269f6
  6. jonathanpeppers
    unassigned
    radekdoulik
    on Jun 14, 2021
  7. jonathanpeppers
    modified the milestones: .NET 6, .NET 7 on Jun 14, 2021
  8. jonpryor
    modified the milestones: .NET 7, .NET 8 on Jul 27, 2022

  9. jonpryor commented on Jul 27, 2022

    @jonpryor
    jonpryor
    on Jul 27, 2022
    Contributor

    Pie-in-the-sky alternative: if jnimarshalmethod-gen ever becomes A Thing, then we can type-forward Java.Interop.ExportAttribute, Mono.Android to Java.Interop.ExportAttribute, Java.Interop and have build-time marshal method generation for [Export] methods.

  10. jonpryor commented on Jul 24, 2023

    @jonpryor
    jonpryor
    on Jul 24, 2023
    Contributor

    This is already fixed, e.g. 15269f6, 6f9bc6b.

    I don't see any [Preserve] in src/Mono.Android.Export.

  11. jonpryor
    closed this as completedon Jul 24, 2023
  12. github-actions
    locked and limited conversation to collaborators on Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area: TrimmingIssues with ILLink or NativeAOT related to trimming.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions