Lazily initialize JCW delegates

Note: all performance numbers mentioned are run on Android Emulator on a DevBox, so they are somewhat inflated.

Imagine we have a Java type that contains a lot of virtual methods:

package foo;

public class DelegateTester 
{
  public long ReturnLongValue1 () { return 0; }
  public long ReturnLongValue2 () { return 0; }
  public long ReturnLongValue3 () { return 0; }
  public long ReturnLongValue4 () { return 0; }
  public long ReturnLongValue5 () { return 0; }
  ... to 100

  public long AddValues () {
    return ReturnLongValue1 () + ReturnLongValue2 () + ReturnLongValue3 () + ReturnLongValue4 () + ReturnLongValue5 () ...;
  }
}

Now imagine we bind it, and override all of those methods:

public class MyDelegateTester : MY.Testpackage.DelegateTester
{
    public override long ReturnLongValue1 () => 1;
    public override long ReturnLongValue2 () => 1;
    public override long ReturnLongValue3 () => 1;
    public override long ReturnLongValue4 () => 1;
    public override long ReturnLongValue5 () => 1;
   ... to 100
}

Then we create an instance of this object in C#: new MyDelegateTester().

For a Release config with marshal methods turned off, this object creation takes ~694ms. (As an aside, this case really shines with marshal methods.)

Scenario	First Object Creation	Second Object Creation	First AddValues Invoke	Second AddValues Invoke
Marshal Methods Off	694ms	0ms	15ms	0ms
Marshal Methods On	55ms	0ms	18ms	0ms

The issue is that we call mono.android.Runtime.register from the static constructor of the generated Java peer type, and this calls the C# generated Get*Handler immediately for every overridden method (in this case 100) even if they aren't immediately used. If we could make these calls lazy instead it would likely improve app startup and navigating to a new activity, since these are places where objects are often created but are not used until later.

Ideally, this could be done in the Java(?) layer as it could then improve all existing bindings. However it could also be done at the binding level.

Instead of:

static Delegate? cb_ReturnLongValue1_ReturnLongValue1_J;

static Delegate GetReturnLongValue1Handler ()
{
  if (cb_ReturnLongValue1_ReturnLongValue1_J == null)
    cb_ReturnLongValue1_ReturnLongValue1_J = JNINativeWrapper.CreateDelegate (new _JniMarshal_PP_J (n_ReturnLongValue1));
  return cb_ReturnLongValue1_ReturnLongValue1_J;
}

We could add an extra level of indirection:

static _JniMarshal_PP_J? cb_ReturnLongValue1_ReturnLongValue1_J;

static Delegate GetReturnLongValue1Handler () => _GetReturnLongValue1Handler;

static long _GetReturnLongValue1Handler(IntPtr jnienv, IntPtr native__this)
{
  if (cb_ReturnLongValue1_ReturnLongValue1_J == null)
    cb_ReturnLongValue1_ReturnLongValue1_J = System.Runtime.CompilerServices.Unsafe.As<_JniMarshal_PP_J>(JNINativeWrapper.CreateDelegate(new _JniMarshal_PP_J(n_ReturnLongValue1)));
  return cb_ReturnLongValue1_ReturnLongValue1_J(jnienv, native__this);
}

Switching to a test case of calling a single method instead of 100, we can see that CreateDelegate cost has moved from the constructor to the first invoke of the method:

Scenario	First Object Creation	Second Object Creation	First AddValues Invoke	Second AddValues Invoke
Original	219ms	0ms	14ms	0ms
Lazy Delegate	42ms	0ms	169ms	0ms

Note: The cost is abnormally high in this example because it is the first call that uses S.R.E, causing the overhead of initializing those APIs.

I like the idea in general, however there is one thing that has to be measured in a larger example is the impact of adding another static field per each overridden method. Static state is cost that cannot be avoided by end user and I generally try to avoid it. Perhaps we could wrap the entire state in a struct instead?

It would be interesting to see results of those tests on a real device. Marshal methods are, by design, 100% lazy - there is no overhead other than Java VM doing a symbol lookup the first time the method is called. 55ms sounds a bit much, but I guess it's Java VM calling dlsym 100 times on libxamarin-app.so, I wonder if this could be somehow improved (probably not).

Ideally, this could be done in the Java(?) layer as it could then improve all existing bindings

I'm not at all sure how to do that.

The problem is that Get*Handler() is expected to return a delegate which can be directly registered with JNIEnv::RegisterNatives():

android/src/Mono.Android/Android.Runtime/AndroidRuntime.cs

Lines 547 to 549 in b667af5

    
           GetCallbackHandler connector = (GetCallbackHandler) Delegate.CreateDelegate (typeof (GetCallbackHandler), 
        
                                                                                        callbackDeclaringType, callbackString.ToString ()); 
        
           callback = connector ();

The only straightforward way to "automatically add" a layer of indirection would be for JNINativeWrapper.CreateDelegate() to do that layer of indirection, which would require Systems.Reflection.Emit, thus defeating the entire idea.

I think this needs to be done in bindings.

What I would prefer is: dotnet/runtime#108211

If/when we have "proper" dotnet/runtime construct that doesn't require System.Reflection.Emit, then we can update generator to make use of it. This would allow us to remove JNINativeWrapper.CreateDelegate() and its use of System.Reflection.Emit from method overrides entirely.

(We would also need such a construct for eventual NativeAOT support. Exception handling must be baked into the binding assemblies, not delegated off to JNINativeWrapper.CreateDelegate(), as the latter cannot possibly work with NativeAOT.)

Building upon my earlier comment, I believe that this would be better, if "we" can get all of our proverbial ducks in a row: dotnet/java-interop#1258

[generator] Remove `JNINativeWrapper.CreateDelegate` from bindings (#…

This is largely fixed by removing SRE from our JCW delegates in .NET 10: dotnet/java-interop#1275.

Navigation Menu

Repository navigation

Lazily initialize JCW delegates #9306

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	GetCallbackHandler connector = (GetCallbackHandler) Delegate.CreateDelegate (typeof (GetCallbackHandler),
	callbackDeclaringType, callbackString.ToString ());
	callback = connector ();

Lazily initialize JCW delegates #9306

Description

Activity

grendello commented on Sep 17, 2024

grendello commented on Sep 17, 2024

jonpryor commented on Sep 24, 2024

jonpryor commented on Sep 25, 2024

jpobst commented on Jan 7, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions