Repository navigation
[ci] Fix network isolation requirements - #11701
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Azure Pipelines CI configuration to better comply with network isolation requirements by disabling .NET SDK background network checks and ensuring dotnet tool installs/updates use restricted NuGet feeds rather than api.nuget.org.
Changes:
- Add
DOTNET_CLI_WORKLOAD_UPDATE_NOTIFY_DISABLEandDOTNET_SDK_VULNERABILITY_CHECK_DISABLEto CI variables. - Update the shared dotnet-tool install template to use an isolated
NuGet.configvia--configfile(removing--add-source https://api.nuget.org/v3/index.json). - Update the darc tool update step to use PowerShell Core and an isolated
NuGet.configvia--configfile.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| build-tools/automation/yaml-templates/variables.yaml | Adds env vars to disable workload update notifications and SDK vulnerability checks to reduce network egress under isolation. |
| build-tools/automation/yaml-templates/install-dotnet-tool.yaml | Writes and uses an isolated NuGet.config for dotnet tool update to avoid nuget.org access. |
| build-tools/automation/azure-pipelines.yaml | Switches darc AzureCLI script to PowerShell Core and uses a cleared-source NuGet.config for darc tool update. |
Address review feedback: '--source' clears default feeds and points only at the required dnceng feed, so we don't need to write a temp NuGet.config and pass '--configfile'. - install-dotnet-tool.yaml (apkdiff, dotnet-test-slicer): only 'dotnet-public' is needed; both tools live on that mirror. - azure-pipelines.yaml (microsoft.dotnet.darc): still needs 'dotnet-eng', which is the only feed darc is published to. Co-authored-by: Copilot <[email protected]>
Member
|
Switched to
Pushed as 265fbc5. |
No longer need pscore now that the inline script doesn't write a temp NuGet.config. Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
jonathanpeppers
approved these changes
Jun 22, 2026
rolfbjarne
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several updates to the build automation configuration, primarily focused on improving network isolation, updating package sources, and ensuring compatibility with Azure DevOps pipelines. The most important changes are grouped below:
Network Isolation Improvements:
DOTNET_CLI_WORKLOAD_UPDATE_NOTIFY_DISABLEandDOTNET_SDK_VULNERABILITY_CHECK_DISABLEinvariables.yamlto address network isolation requirements and disable certain .NET notifications and vulnerability checks.Package Source Updates:
install-dotnet-tool.yamlfrom the public NuGet feed to the internal Azure DevOps feed (dotnet-public).darctool installation inazure-pipelines.yamlto use--sourceinstead of the deprecated--add-sourceparameter, aligning with current .NET CLI conventions.These changes help ensure builds are more reliable in isolated network environments and modernize the way .NET tools are installed.