Repository navigation
[release/11.0.1xx] Reject legacy AOT disable on CoreCLR - #12960
Merged
jonathanpeppers merged 2 commits intoOct 1, 2026
Merged
Conversation
Backport #12956 to release/11.0.1xx, capturing the explicitly disabled setting before Mono AOT defaults are applied. Preserve Mono and NativeAOT behavior and update diagnostics, docs, and configuration tests. Co-authored-by: Copilot App <[email protected]>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new condition breaks the repository’s documented profiled-AOT regeneration workflow unless its legacy property usage is migrated.
Review effort: Balanced
Findings: 1
What changed in this PR
Backports XA1044 handling for explicitly disabled legacy AOT on CoreCLR.
Changes:
- Captures
RunAOTCompilation=falsebefore defaults are applied. - Adds diagnostics, documentation, and regression tests.
- Preserves MonoVM and NativeAOT handling.
| File | Description |
|---|---|
Xamarin.Android.Common.targets |
Emits the new XA1044 diagnostic. |
InvalidConfigTests.cs |
Tests runtime and AOT property combinations. |
Resources.resx |
Adds the localized diagnostic. |
Resources.Designer.cs |
Exposes the generated resource property. |
Microsoft.Android.Sdk.DefaultProperties.targets |
Captures explicit legacy AOT disablement. |
xa1044.md |
Documents XA1044 behavior and resolution. |
build-properties.md |
Documents updated AOT property semantics. |
Files not reviewed (1)
- src/Xamarin.Android.Build.Tasks/Properties/Resources.Designer.cs: Generated file
CoreCLR test projects formerly set RunAOTCompilation=false through AotAssemblies and per-ABI test setup. With XA1044 rejecting that legacy property, these fixtures fail before reaching the behavior they test. Omit Mono AOT settings for CoreCLR, retaining intentional invalid-configuration coverage and existing ReadyToRun defaults. Co-authored-by: Copilot App <[email protected]>
jonathanpeppers
added
the
ready-to-review
Member
Author
|
@dalexsoto review |
jonathanpeppers
enabled auto-merge (squash)
October 1, 2026 16:51
Member
Author
|
@dalexsoto review |
dalexsoto
approved these changes
Oct 1, 2026
dalexsoto
left a comment
dalexsoto
left a comment
Member
There was a problem hiding this comment.
The backport captures explicit RunAOTCompilation=false before CoreCLR's defaults and reports XA1044 with the correct PublishReadyToRun=false guidance. The complete current change preserves MonoVM and NativeAOT handling, migrates affected callers, and keeps diagnostic resources, generated accessors and documentation aligned. No current blocking issue remains; the accepted Mono-only profiled-AOT workflow is non-blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12956 to
release/11.0.1xx.The release branch retains Mono AOT defaults, so capture an explicitly disabled
RunAOTCompilationon CoreCLR before those defaults are applied. Report XA1044 with guidance to setPublishReadyToRun=false; preserve existing Mono and NativeAOT behavior. Update the diagnostic, documentation, and configuration tests. No prerequisite commits were needed.Validation: 18 targeted MSBuild property evaluations passed across CoreCLR, MonoVM, NativeAOT, ReadyToRun, legacy AOT, and LLVM; XML/resource parsing and
git diff --checkpassed. Full integration tests could not be run locally because this checkout lacks the required Java/Android build prerequisites.